From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39012)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Rkfs7-0006FZ-Jv
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 12:52:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Rkfs6-0000OR-Gq
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 12:52:31 -0500
Received: from mail-lpp01m010-f45.google.com ([209.85.215.45]:46852)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Rkfs6-0000O2-Ak
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 12:52:30 -0500
Received: by lagy4 with SMTP id y4so2228305lag.4
	for <qemu-devel@nongnu.org>; Tue, 10 Jan 2012 09:52:29 -0800 (PST)
Date: Tue, 10 Jan 2012 18:52:22 +0100
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20120110175221.GB14726@zapo>
References: <1325793761-10249-1-git-send-email-mark.langsdorf@calxeda.com>
	<1326128349-3465-1-git-send-email-mark.langsdorf@calxeda.com>
	<1326128349-3465-2-git-send-email-mark.langsdorf@calxeda.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1326128349-3465-2-git-send-email-mark.langsdorf@calxeda.com>
Subject: Re: [Qemu-devel] [PATCH v5 1/6] Add xgmac ethernet model
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark Langsdorf <mark.langsdorf@calxeda.com>
Cc: i.mitsyanko@gmail.com, peter.maydell@linaro.org, qemu-devel@nongnu.org, Rob Herring <rob.herring@calxeda.com>, afaerber@suse.de

On Mon, Jan 09, 2012 at 10:59:04AM -0600, Mark Langsdorf wrote:
> This adds very basic support for XG-mac ethernet core from Synopsis and
> others. Missing things include:
> 
> - statistics counters
> - WoL support
> - rx checksum offload
> - chained descriptors (only linear descriptor ring)
> - broadcast and multicast handling
> 
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Signed-off-by: Mark Langsdorf <mark.langsdorf@calxeda.com>
> ---
> Changes from v4
>         None
> Changes from v3
>         Added debug macro and cleaned up some debug code
>         Refitted all lines to fit within 80 columns
> Changes from v2
>         None
> Changes from v1
>         Reformated most lines to fit within 80 columns
>         Removed a bunch of unused variables in the state structures
>         Got rid of some camelcase structure names


Hi, this looks good to me, just one question. Do you really need
the c_phyaddr member?

Cheers