From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59371)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1RkkzS-0006Dm-Hs
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 18:20:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1RkkzQ-0006p6-Ul
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 18:20:26 -0500
Received: from mail-lpp01m010-f45.google.com ([209.85.215.45]:63813)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1RkkzQ-0006oX-JW
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 18:20:24 -0500
Received: by lagy4 with SMTP id y4so76631lag.4
	for <qemu-devel@nongnu.org>; Tue, 10 Jan 2012 15:20:23 -0800 (PST)
Date: Wed, 11 Jan 2012 00:20:17 +0100
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20120110232017.GA10937@zapo>
References: <1326191247-14880-1-git-send-email-edgar.iglesias@gmail.com>
	<4F0CC777.3000904@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F0CC777.3000904@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] microblaze: Add support for the clz insn
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Wed, Jan 11, 2012 at 10:19:19AM +1100, Richard Henderson wrote:
> On 01/10/2012 09:27 PM, Edgar E. Iglesias wrote:
> > +++ b/target-microblaze/helper.h
> > @@ -5,6 +5,7 @@ DEF_HELPER_0(debug, void)
> >  DEF_HELPER_FLAGS_3(carry, TCG_CALL_PURE | TCG_CALL_CONST, i32, i32, i32, i32)
> >  DEF_HELPER_2(cmp, i32, i32, i32)
> >  DEF_HELPER_2(cmpu, i32, i32, i32)
> > +DEF_HELPER_1(clz, i32, i32)
> 
> Use DEF_HELPER_FLAGS_1 with PURE|CONST, since the function examines 
> nothing but its arguments.

Yep thank, noticed that when I changed the helper today :)

Cheers