From: Christoph Hellwig <hch@infradead.org>
To: Gregory Farnum <gregory.farnum@dreamhost.com>
Cc: ceph-devel@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH]: set up rbd snapshot handling
Date: Wed, 11 Jan 2012 05:00:04 -0500 [thread overview]
Message-ID: <20120111100004.GA30381@infradead.org> (raw)
In-Reply-To: <CAF3hT9Cu0BZQfrgCpBRRaPHyfSy3V-A=jJLe3qGr4UoFMcniOQ@mail.gmail.com>
> +static int qemu_rbd_snap_remove(BlockDriverState *bs,
> + const char *snapshot_name)
> +{
> + BDRVRBDState *s = bs->opaque;
> + int r;
> +
> + r = rbd_snap_remove(s->image, snapshot_name);
> + r = rbd_snap_rollback(s->image, snapshot_name);
Have these functions been available since day 1 in librbd or should they
get a version checks like the cache flush call?
next prev parent reply other threads:[~2012-01-11 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 20:01 [Qemu-devel] [PATCH]: set up rbd snapshot handling Gregory Farnum
2012-01-11 9:58 ` Stefan Hajnoczi
2012-01-11 10:00 ` Christoph Hellwig [this message]
2012-01-11 19:48 ` Gregory Farnum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111100004.GA30381@infradead.org \
--to=hch@infradead.org \
--cc=ceph-devel@vger.kernel.org \
--cc=gregory.farnum@dreamhost.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).