* [Qemu-devel] [PATCH] virtfs-proxy-helper: Add missing printf format attribute
@ 2012-01-11 18:47 Stefan Weil
2012-01-12 13:52 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2012-01-11 18:47 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Stefan Weil, M. Mohan Kumar, Aneesh Kumar K.V
Every function with printf like arguments must have it
(see file HACKING), so add it.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
fsdev/virtfs-proxy-helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index 21e9b16..4a507d8 100644
--- a/fsdev/virtfs-proxy-helper.c
+++ b/fsdev/virtfs-proxy-helper.c
@@ -54,7 +54,7 @@ static struct option helper_opts[] = {
static bool is_daemon;
static bool get_version; /* IOC getversion IOCTL supported */
-static void do_log(int loglevel, const char *format, ...)
+static void GCC_FMT_ATTR(2, 3) do_log(int loglevel, const char *format, ...)
{
va_list ap;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] virtfs-proxy-helper: Add missing printf format attribute
2012-01-11 18:47 [Qemu-devel] [PATCH] virtfs-proxy-helper: Add missing printf format attribute Stefan Weil
@ 2012-01-12 13:52 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2012-01-12 13:52 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, M. Mohan Kumar, qemu-devel, Aneesh Kumar K.V
On Wed, Jan 11, 2012 at 07:47:37PM +0100, Stefan Weil wrote:
> Every function with printf like arguments must have it
> (see file HACKING), so add it.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> fsdev/virtfs-proxy-helper.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-12 13:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-11 18:47 [Qemu-devel] [PATCH] virtfs-proxy-helper: Add missing printf format attribute Stefan Weil
2012-01-12 13:52 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).