From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rljey-00010r-N4 for qemu-devel@nongnu.org; Fri, 13 Jan 2012 11:07:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rljex-0003UX-Ic for qemu-devel@nongnu.org; Fri, 13 Jan 2012 11:07:20 -0500 Date: Fri, 13 Jan 2012 17:07:06 +0100 From: Aurelien Jarno Message-ID: <20120113160706.GC6244@volta.aurel32.net> References: <1325966978-940-1-git-send-email-aurelien@aurel32.net> <1325966978-940-5-git-send-email-aurelien@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 4/4] target-i386: fix SSE rounding and flush to zero List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dong Xu Wang Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org On Thu, Jan 12, 2012 at 01:37:59PM +0800, Dong Xu Wang wrote: > After applied this patch, while I was compiling on my lap, there will > be an error: > > ./configure --enable-kvm --target-list=x86_64-softmmu && make > CC x86_64-softmmu/translate.o > /qemu/target-i386/translate.c: In function ‘disas_insn’: > /qemu/target-i386/translate.c:7547:17: error: incompatible type for > argument 1 of ‘gen_helper_ldmxcsr’ > /qemu/target-i386/helper.h:200:1: note: expected ‘TCGv_i32’ but > argument is of type ‘TCGv_i64’ > make[1]: *** [translate.o] Error 1 > make: *** [subdir-x86_64-softmmu] Error 2 Sorry about that, I have pushed the following patch which solves the problem. target-i386: fix compilation with --enable-debug-tcg Commit 2355c16e74ffa4d14e7fc2b4a23b055565ac0221 introduced a new ldmxcsr helper taking an i32 argument, but the helper is actually passed a long. Fix that by truncating the long to i32. Signed-off-by: Aurelien Jarno --- target-i386/translate.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index b9839c5..860b4a3 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -7544,7 +7544,8 @@ static target_ulong disas_insn(DisasContext *s, target_ulong pc_start) gen_lea_modrm(s, modrm, ®_addr, &offset_addr); if (op == 2) { gen_op_ld_T0_A0(OT_LONG + s->mem_index); - gen_helper_ldmxcsr(cpu_T[0]); + tcg_gen_trunc_tl_i32(cpu_tmp2_i32, cpu_T[0]); + gen_helper_ldmxcsr(cpu_tmp2_i32); } else { tcg_gen_ld32u_tl(cpu_T[0], cpu_env, offsetof(CPUX86State, mxcsr)); gen_op_st_T0_A0(OT_LONG + s->mem_index); -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net