From: Michael Walle <michael@walle.cc>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Andreas Färber" <afaerber@suse.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 01/14] lm32: Fix mixup of uint32 and uint32_t
Date: Mon, 16 Jan 2012 22:39:38 +0100 [thread overview]
Message-ID: <201201162239.38327.michael@walle.cc> (raw)
In-Reply-To: <CAFEAcA9npZFvAPbvLDin75Jj=iiOZNgk2xZepoisntZh_BDKRQ@mail.gmail.com>
Am Montag 16 Januar 2012, 12:27:01 schrieb Peter Maydell:
> On 16 January 2012 00:46, Andreas Färber <afaerber@suse.de> wrote:
> > diff --git a/hw/milkymist-vgafb_template.h
> > b/hw/milkymist-vgafb_template.h index 69af9ef..544b55e 100644
> > --- a/hw/milkymist-vgafb_template.h
> > +++ b/hw/milkymist-vgafb_template.h
> > @@ -39,7 +39,7 @@
> > #elif BITS == 24
> > #define COPY_PIXEL(to, r, g, b) \
> > do { \
> > - uint32 tmp = rgb_to_pixel24(r, g, b); \
> > + uint32_t tmp = rgb_to_pixel24(r, g, b); \
> > *(to++) = tmp & 0xff; \
> > *(to++) = (tmp >> 8) & 0xff; \
> > *(to++) = (tmp >> 16) & 0xff; \
>
> This change breaks the otherwise consistent alignment of the '\'
> characters in column 51...
apart from that,
Acked-by: Michael Walle <michael@walle.cc>
--
michael
next prev parent reply other threads:[~2012-01-16 21:39 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 0:46 [Qemu-devel] [PATCH 00/14] softfloat: Use POSIX integer types - benchmarked Andreas Färber
2012-01-16 0:46 ` [Qemu-devel] [PATCH 01/14] lm32: Fix mixup of uint32 and uint32_t Andreas Färber
2012-01-16 11:27 ` Peter Maydell
2012-01-16 12:18 ` Andreas Färber
2012-01-16 21:39 ` Michael Walle [this message]
2012-01-17 9:44 ` [Qemu-devel] [PATCH v2] " Andreas Färber
2012-01-19 8:17 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-01-16 0:46 ` [Qemu-devel] [PATCH 02/14] target-sparc: Fix mixup of uint64 and uint64_t Andreas Färber
2012-01-21 18:51 ` Blue Swirl
2012-01-22 2:03 ` Andreas Färber
2012-01-22 8:09 ` Blue Swirl
2012-01-22 10:02 ` Blue Swirl
2012-01-16 0:46 ` [Qemu-devel] [PATCH 03/14] qemu-tool: Fix mixup of int64 and int64_t Andreas Färber
2012-01-16 8:11 ` Stefan Hajnoczi
2012-01-16 0:46 ` [Qemu-devel] [PATCH 04/14] softfloat: Fix mixups of int and int16 Andreas Färber
2012-01-16 17:51 ` Peter Maydell
2012-01-16 0:46 ` [Qemu-devel] [PATCH 05/14] target-mips: Move definition of uint_fast{8, 16}_t to osdep.h Andreas Färber
2012-01-16 11:38 ` Peter Maydell
2012-01-16 12:13 ` Andreas Färber
2012-01-16 12:21 ` Peter Maydell
2012-01-16 12:24 ` Andreas Färber
2012-01-16 0:46 ` [Qemu-devel] [PATCH 06/14] softfloat: Replace uint16 type with uint_fast16_t Andreas Färber
2012-01-16 18:43 ` Peter Maydell
2012-01-16 0:46 ` [Qemu-devel] [PATCH 07/14] softfloat: Replace int16 type with int_fast16_t Andreas Färber
2012-01-16 0:46 ` [Qemu-devel] [PATCH 08/14] softfloat: Remove unused uint8 type Andreas Färber
2012-01-16 0:46 ` [Qemu-devel] [PATCH 09/14] softfloat: Replace int8 type with int_fast8_t Andreas Färber
2012-01-16 18:48 ` Peter Maydell
2012-01-16 0:46 ` [Qemu-devel] [PATCH 10/14] softfloat: Replace uint32 type with uint_fast32_t Andreas Färber
2012-01-16 0:47 ` [Qemu-devel] [PATCH 11/14] softfloat: Replace int32 type with int_fast32_t Andreas Färber
2012-01-16 0:47 ` [Qemu-devel] [PATCH 12/14] softfloat: Replace uint64 type with uint_fast64_t Andreas Färber
2012-01-16 0:47 ` [Qemu-devel] [PATCH 13/14] softfloat: Replace int64 type with int_fast64_t Andreas Färber
2012-01-16 0:47 ` [Qemu-devel] [PATCH 14/14] softfloat: Replace flag type with bool Andreas Färber
2012-01-16 19:02 ` [Qemu-devel] [PATCH 00/14] softfloat: Use POSIX integer types - benchmarked Peter Maydell
2012-01-16 19:12 ` Alexander Graf
2012-01-16 19:17 ` Peter Maydell
2012-01-16 19:18 ` Alexander Graf
2012-01-16 23:52 ` Peter Maydell
2012-01-17 0:05 ` Alexander Graf
2012-01-20 13:05 ` Peter Maydell
2012-01-23 17:41 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201162239.38327.michael@walle.cc \
--to=michael@walle.cc \
--cc=afaerber@suse.de \
--cc=edgar.iglesias@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).