From: Alon Levy <alevy@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qxl: Slot sanity check in qxl_phys2virt() is off by one, fix
Date: Tue, 17 Jan 2012 13:57:41 +0200 [thread overview]
Message-ID: <20120117115704.GH5773@garlic> (raw)
In-Reply-To: <m3hazud7c0.fsf@blackfin.pond.sub.org>
On Tue, Jan 17, 2012 at 10:08:47AM +0100, Markus Armbruster wrote:
> Ping?
>
> Markus Armbruster <armbru@redhat.com> writes:
>
Reviewed-by: Alon Levy <alevy@redhat.com>
> > Spotted by Coverity.
> >
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> > ---
> > hw/qxl.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/hw/qxl.c b/hw/qxl.c
> > index 84ffd45..c97bebe 100644
> > --- a/hw/qxl.c
> > +++ b/hw/qxl.c
> > @@ -1006,7 +1006,7 @@ void *qxl_phys2virt(PCIQXLDevice *qxl, QXLPHYSICAL pqxl, int group_id)
> > case MEMSLOT_GROUP_HOST:
> > return (void*)offset;
> > case MEMSLOT_GROUP_GUEST:
> > - PANIC_ON(slot > NUM_MEMSLOTS);
> > + PANIC_ON(slot >= NUM_MEMSLOTS);
> > PANIC_ON(!qxl->guest_slots[slot].active);
> > PANIC_ON(offset < qxl->guest_slots[slot].delta);
> > offset -= qxl->guest_slots[slot].delta;
>
next prev parent reply other threads:[~2012-01-17 11:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 9:34 [Qemu-devel] [PATCH] qxl: Slot sanity check in qxl_phys2virt() is off by one, fix Markus Armbruster
2011-11-09 12:33 ` Gerd Hoffmann
2012-01-17 9:08 ` Markus Armbruster
2012-01-17 11:57 ` Alon Levy [this message]
2012-01-17 15:50 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2012-01-17 15:51 [Qemu-devel] [PULL] tiny spice patch queue Gerd Hoffmann
2012-01-17 15:51 ` [Qemu-devel] [PATCH] qxl: Slot sanity check in qxl_phys2virt() is off by one, fix Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120117115704.GH5773@garlic \
--to=alevy@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).