qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: 陳韋任 <chenwj@iis.sinica.edu.tw>
To: James Greensky <gsky51@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] icount and tb chaining
Date: Tue, 17 Jan 2012 23:06:47 +0800	[thread overview]
Message-ID: <20120117150647.GA61848@cs.nctu.edu.tw> (raw)
In-Reply-To: <CAK2fC=3rrr8vU7j9QJ7mVoMJu4tie2i=fBzSwYKdxFSRAL=qTQ@mail.gmail.com>

> a jump with the least significant bits = 2. This falls through to tb
> add jump, which then updates the jmp_first field of the current tb.

  I don't know if tb_add_jump's second parameter will be two or not, but
look at TranslationBlock (exec-all.h),

struct TranslationBlock {

  struct TranslationBlock *jmp_next[2];

}

and tb_add_jump (exec-all.h).

static inline void tb_add_jump(TranslationBlock *tb, int n,
                               TranslationBlock *tb_next)
{
    /* NOTE: this test is only needed for thread safety */
    if (!tb->jmp_next[n]) { <--- what if n is 2? 
    }
}

Regards,
chenwj

-- 
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj

  parent reply	other threads:[~2012-01-17 15:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-12 19:00 [Qemu-devel] icount and tb chaining James Greensky
2012-01-12 19:02 ` James Greensky
2012-01-13  3:41 ` 陳韋任
2012-01-13 18:39   ` James Greensky
2012-01-17 18:50     ` Peter Maydell
2012-01-17 19:06       ` Laurent Desnogues
2012-01-17 19:08         ` Laurent Desnogues
2012-01-17 19:55       ` James Greensky
2012-01-18  3:22     ` 陳韋任
2012-01-18 19:49       ` James Greensky
2012-01-19 10:32         ` 陳韋任
2012-01-24 19:00           ` James Greensky
2012-01-17 15:06 ` 陳韋任 [this message]
2012-01-17 19:52   ` James Greensky
2012-01-18  3:03     ` 陳韋任
2012-01-18 19:43       ` James Greensky
2012-01-18 19:50         ` Peter Maydell
2012-01-19  2:42           ` 陳韋任

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120117150647.GA61848@cs.nctu.edu.tw \
    --to=chenwj@iis.sinica.edu.tw \
    --cc=gsky51@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).