From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43625)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1RnwRL-0006cc-Ct
	for qemu-devel@nongnu.org; Thu, 19 Jan 2012 13:10:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1RnwRF-0002Kv-E0
	for qemu-devel@nongnu.org; Thu, 19 Jan 2012 13:10:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:32777)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1RnwRF-0002Kl-7O
	for qemu-devel@nongnu.org; Thu, 19 Jan 2012 13:10:17 -0500
Date: Thu, 19 Jan 2012 16:08:51 -0200
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20120119180851.GA19099@amt.cnet>
References: <cover.1326972302.git.jan.kiszka@siemens.com>
	<6a48ffaaa732b2142c1b5030178f2d4a0fa499fe.1326972302.git.jan.kiszka@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6a48ffaaa732b2142c1b5030178f2d4a0fa499fe.1326972302.git.jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] [PATCH v8 18/18] kvm: Activate in-kernel irqchip
	support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>

On Thu, Jan 19, 2012 at 12:25:10PM +0100, Jan Kiszka wrote:
> Make the basic in-kernel irqchip support selectable via
> -machine ...,kernel_irqchip=on. Leave it off by default until it can
> fully replace user space models.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  qemu-config.c   |    4 ++++
>  qemu-options.hx |    5 ++++-
>  2 files changed, 8 insertions(+), 1 deletions(-)
> 
> diff --git a/qemu-config.c b/qemu-config.c
> index ecc88e8..b030205 100644
> --- a/qemu-config.c
> +++ b/qemu-config.c
> @@ -531,6 +531,10 @@ static QemuOptsList qemu_machine_opts = {
>              .name = "accel",
>              .type = QEMU_OPT_STRING,
>              .help = "accelerator list",
> +        }, {
> +            .name = "kernel_irqchip",
> +            .type = QEMU_OPT_BOOL,
> +            .help = "use KVM in-kernel irqchip",
>          },
>          { /* End of list */ }
>      },


Pulled (and pushed), but you forgot to actually hook this option to kvm_irqchip_in_kernel?