From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60233)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1RpQ5l-0000uC-VL
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 15:02:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1RpQ5Z-0008Dn-ID
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 15:02:13 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59004)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1RpQ5Z-0008Dc-4V
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 15:02:01 -0500
Date: Mon, 23 Jan 2012 20:01:55 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20120123200155.GA7286@redhat.com>
References: <cover.1327346110.git.jan.kiszka@siemens.com>
	<b4a4da9c3ce17f84278c489549ea5f7be8f4321c.1327346110.git.jan.kiszka@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <b4a4da9c3ce17f84278c489549ea5f7be8f4321c.1327346110.git.jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] qdev: Introduce lost tick policy
	property
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>

On Mon, Jan 23, 2012 at 08:15:11PM +0100, Jan Kiszka wrote:
> Potentially tick-generating timer devices will gain a common property:
> lock_tick_policy. It allows to encode 4 different ways how to deal with
> tick events the guest did not process in time:
> 
> discard - ignore lost ticks (e.g. if the guest compensates for them
>           already)
> delay   - replay all lost ticks in a row once the guest accepts them
>           again
> merge   - if multiple ticks are lost, all of them are merged into one
>           which is replayed once the guest accepts it again
> slew    - lost ticks are gradually replayed at a higher frequency than
>           the original tick
> 
> Not all timer device will need to support all modes. However, all need
> to accept the configuration via this common property.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

That looks good - thank you for making the effort to come up with
something that maps so well to the libvirt model for this concept.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|