From: David Gibson <david@gibson.dropbear.id.au>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: Pseries: Check for PCI boundaries
Date: Tue, 24 Jan 2012 11:56:40 +1100 [thread overview]
Message-ID: <20120124005640.GT4512@truffala.fritz.box> (raw)
In-Reply-To: <20120118172833.GC2665@redhat.com>
On Wed, Jan 18, 2012 at 07:28:33PM +0200, Michael S. Tsirkin wrote:
> On Wed, Jan 18, 2012 at 05:24:50PM +0100, Alexander Graf wrote:
> > We call pci_host_config_{read,write}_common() which perform PCI config
> > accesses. However they don't do all limit checking the way we expect
> > it to.
> >
> > So let's introduce a small wrapper around them, making them behave the
> > way we would without touching generic code.
> >
> > This patch is based on a patch by David Gibson which put this logic into
> > the generic code.
> >
> > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > Signed-off-by: Alexander Graf <agraf@suse.de>
>
> Nod. Looks like a sensible way to fix pseries without
> bothering about breaking other arches.
Yeah. I still think the bounds check should be done in common code,
but I'll make up another patch to push it there later.
Apologies for earlier comments on the matter, I've had a very
frustrating month :/
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
prev parent reply other threads:[~2012-01-24 0:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 16:24 [Qemu-devel] [PATCH] PPC: Pseries: Check for PCI boundaries Alexander Graf
2012-01-18 17:28 ` Michael S. Tsirkin
2012-01-24 0:56 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120124005640.GT4512@truffala.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).