From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43565)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1RpUh2-0007kN-B5
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 19:57:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1RpUh0-0004T1-6x
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 19:57:00 -0500
Date: Tue, 24 Jan 2012 11:56:40 +1100
From: David Gibson <david@gibson.dropbear.id.au>
Message-ID: <20120124005640.GT4512@truffala.fritz.box>
References: <1326903890-2924-1-git-send-email-agraf@suse.de>
	<20120118172833.GC2665@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120118172833.GC2665@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: Pseries: Check for PCI
	boundaries
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org

On Wed, Jan 18, 2012 at 07:28:33PM +0200, Michael S. Tsirkin wrote:
> On Wed, Jan 18, 2012 at 05:24:50PM +0100, Alexander Graf wrote:
> > We call pci_host_config_{read,write}_common() which perform PCI config
> > accesses. However they don't do all limit checking the way we expect
> > it to.
> > 
> > So let's introduce a small wrapper around them, making them behave the
> > way we would without touching generic code.
> > 
> > This patch is based on a patch by David Gibson which put this logic into
> > the generic code.
> > 
> > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > Signed-off-by: Alexander Graf <agraf@suse.de>
> 
> Nod. Looks like a sensible way to fix pseries without
> bothering about breaking other arches.

Yeah.  I still think the bounds check should be done in common code,
but I'll make up another patch to push it there later.

Apologies for earlier comments on the matter, I've had a very
frustrating month :/

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson