From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpmYd-0000nr-PT for qemu-devel@nongnu.org; Tue, 24 Jan 2012 15:01:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RpmYa-0008Kg-BU for qemu-devel@nongnu.org; Tue, 24 Jan 2012 15:01:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:65021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpmYa-0008K6-2H for qemu-devel@nongnu.org; Tue, 24 Jan 2012 15:01:28 -0500 Date: Wed, 25 Jan 2012 01:29:50 +0530 From: Amit Shah Message-ID: <20120124195950.GD320@amit.redhat.com> References: <1327433600-7403-1-git-send-email-aliguori@us.ibm.com> <1327433600-7403-23-git-send-email-aliguori@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1327433600-7403-23-git-send-email-aliguori@us.ibm.com> Subject: Re: [Qemu-devel] [PATCH 22/28] virtio-serial: convert to QEMU Object Model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On (Tue) 24 Jan 2012 [13:33:14], Anthony Liguori wrote: > diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c > index 982ffbf..edf54d7 100644 > --- a/hw/virtio-serial-bus.c > +++ b/hw/virtio-serial-bus.c > @@ -157,7 +157,7 @@ static void do_flush_queued_data(VirtIOSerialPort *port, VirtQueue *vq, > ssize_t ret; > > buf_size = port->elem.out_sg[i].iov_len - port->iov_offset; > - ret = info->have_data(port, > + ret = vsc->have_data(port, > port->elem.out_sg[i].iov_base > + port->iov_offset, > buf_size); Would be nice if everything was re-indented. > @@ -176,7 +176,7 @@ static void do_flush_queued_data(VirtIOSerialPort *port, VirtQueue *vq, > * 1: chardevs can notify frondends > * 2: the guest driver does not spin in these cases > */ > - if (!info->is_console) { > + if (vsc->is_console) { > virtio_serial_throttle_port(port, true); > } > port->iov_idx = i; This change is wrong, reverses the if condition. Was this done manually or via a script? If the latter, it would be worthwhile to check all the conversions. > -void virtio_serial_port_qdev_register(VirtIOSerialPortInfo *info) > +void virtio_serial_port_qdev_register(DeviceInfo *info) Should the fn be renamed (replace qdev)? Amit