From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:41674)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Rq37G-0005Vi-68
	for qemu-devel@nongnu.org; Wed, 25 Jan 2012 08:42:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Rq37F-0001BV-6Y
	for qemu-devel@nongnu.org; Wed, 25 Jan 2012 08:42:22 -0500
Received: from mx1.redhat.com ([209.132.183.28]:1792)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Rq37F-0001BI-01
	for qemu-devel@nongnu.org; Wed, 25 Jan 2012 08:42:21 -0500
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0PDgKlW003778
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 25 Jan 2012 08:42:20 -0500
Date: Wed, 25 Jan 2012 11:42:16 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120125114216.5d41c705@doriath.home>
In-Reply-To: <4F20026B.4020801@redhat.com>
References: <20120124161628.4bf2592c@doriath.home>
	<4F1F0E9F.8080302@redhat.com> <4F1FC030.2030705@redhat.com>
	<20120125104204.55eec0a1@doriath.home>
	<4F20026B.4020801@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Eric Blake <eblake@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>

On Wed, 25 Jan 2012 14:23:55 +0100
Kevin Wolf <kwolf@redhat.com> wrote:

> >> Also, I seem to remember that once we had discussed some kind of a "tray
> >> status (open/closed) changed" event, which would be more generic.
> > 
> > Yes, but my old series got complex and way beyond the original event. If we
> > decide to cover all eject scenarios, I'd like to do it w/o adding new commands.
> 
> I don't really remember. Were it problems with the design of a tray
> status event or were you sidetracked by other problems?

I was also trying to fix the 'change' command. So I added new commands to
open, close and insert a medium in the tray. Then we had TRAY_OPEN & TRAY_CLOSE
events... It was a 10 patch series iirc.