From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rq28t-0001sF-Un for qemu-devel@nongnu.org; Wed, 25 Jan 2012 07:40:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rq28p-0003nI-Ji for qemu-devel@nongnu.org; Wed, 25 Jan 2012 07:39:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16367) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rq28p-0003n8-7e for qemu-devel@nongnu.org; Wed, 25 Jan 2012 07:39:55 -0500 Date: Wed, 25 Jan 2012 14:42:10 +0200 From: "Michael S. Tsirkin" Message-ID: <20120125124210.GB22203@redhat.com> References: <1327433600-7403-1-git-send-email-aliguori@us.ibm.com> <1327433600-7403-4-git-send-email-aliguori@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1327433600-7403-4-git-send-email-aliguori@us.ibm.com> Subject: Re: [Qemu-devel] [PATCH 03/28] pci: call reset unconditionally List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On Tue, Jan 24, 2012 at 01:32:55PM -0600, Anthony Liguori wrote: > Because now all PCI devices are converted to qdev. > > Signed-off-by: Anthony Liguori Finally! > --- > hw/pci.c | 7 ++----- > 1 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c > index 54400ac..ab3b53d 100644 > --- a/hw/pci.c > +++ b/hw/pci.c > @@ -159,11 +159,8 @@ void pci_device_deassert_intx(PCIDevice *dev) > void pci_device_reset(PCIDevice *dev) > { > int r; > - /* TODO: call the below unconditionally once all pci devices > - * are qdevified */ > - if (dev->qdev.info) { > - qdev_reset_all(&dev->qdev); > - } > + > + qdev_reset_all(&dev->qdev); > > dev->irq_state = 0; > pci_update_irq_status(dev); > -- > 1.7.4.1