From: Grant Likely <grant.likely@secretlab.ca>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] arm: add device tree support
Date: Mon, 30 Jan 2012 06:31:58 -0700 [thread overview]
Message-ID: <20120130133158.GF28397@ponder.secretlab.ca> (raw)
In-Reply-To: <4F2680C8.8040108@suse.de>
On Mon, Jan 30, 2012 at 12:36:40PM +0100, Andreas Färber wrote:
> Am 29.01.2012 21:36, schrieb Grant Likely:
> > On Sun, Jan 29, 2012 at 07:13:55PM +0000, Peter Maydell wrote:
> >> On 29 January 2012 16:01, Grant Likely <grant.likely@secretlab.ca> wrote:
> >>> +DEF("dtb", HAS_ARG, QEMU_OPTION_dtb, \
> >>> + "-dtb file use 'file' as a device tree image\n", QEMU_ARCH_ARM)
> >>
> >> Needs more spaces to make it line up right in -help output:
> >> Linux/Multiboot boot specific:
> >> -kernel bzImage use 'bzImage' as kernel image
> >> -append cmdline use 'cmdline' as kernel command line
> >> -initrd file use 'file' as initial ram disk
> >> -dtb file use 'file' as a device tree image
> >
> > Fixed.
> >
> > New patch below...
> >
> > ---
> > diff --git a/Makefile.target b/Makefile.target
> > index 68481a3..5e465ec 100644
> > --- a/Makefile.target
> > +++ b/Makefile.target
> [snip]
>
> Please always post patches using git-send-email and indicate the version
> number as [PATCH vX] (opinions are divided whether as reply or as
> top-level). The changes should be described below the commit message (or
> in a cover letter).
>
> http://wiki.qemu.org/Contribute/SubmitAPatch
>
> Andreas
I was really only including the new versions in my replies to shorten
up the review cycle. I'll repost correctly when it looks like all
comments are resolved.
g.
next prev parent reply other threads:[~2012-01-30 13:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 21:53 [Qemu-devel] [PATCH] arm: add device tree support Grant Likely
2012-01-27 22:34 ` Paul Brook
2012-01-28 18:48 ` Grant Likely
2012-01-29 11:15 ` Paul Brook
2012-01-29 16:01 ` Grant Likely
2012-01-29 18:48 ` Andreas Färber
2012-01-29 21:29 ` Peter Maydell
2012-01-30 13:33 ` Grant Likely
2012-01-29 19:13 ` Peter Maydell
2012-01-29 20:36 ` Grant Likely
2012-01-30 11:36 ` Andreas Färber
2012-01-30 13:31 ` Grant Likely [this message]
2012-01-30 0:24 ` John Williams
2012-01-29 20:42 ` Edgar E. Iglesias
2012-01-29 23:54 ` Peter Crosthwaite
2012-01-30 13:40 ` Grant Likely
-- strict thread matches above, loose matches on Subject: below --
2012-01-29 7:48 Peter Crosthwaite
2012-02-22 19:48 Peter Maydell
2012-02-27 17:38 Peter Maydell
2012-02-27 17:41 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130133158.GF28397@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).