From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RrrL6-0007aj-VQ for qemu-devel@nongnu.org; Mon, 30 Jan 2012 08:32:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RrrKz-0000Jt-Vm for qemu-devel@nongnu.org; Mon, 30 Jan 2012 08:32:08 -0500 Received: from mail-yx0-f173.google.com ([209.85.213.173]:45429) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RrrKz-0000Jn-Pu for qemu-devel@nongnu.org; Mon, 30 Jan 2012 08:32:01 -0500 Received: by yenl8 with SMTP id l8so2213273yen.4 for ; Mon, 30 Jan 2012 05:32:01 -0800 (PST) Sender: Grant Likely Date: Mon, 30 Jan 2012 06:31:58 -0700 From: Grant Likely Message-ID: <20120130133158.GF28397@ponder.secretlab.ca> References: <1327701190-24822-1-git-send-email-grant.likely@secretlab.ca> <201201272234.02700.paul@codesourcery.com> <20120128184837.GG2501@ponder.secretlab.ca> <201201291115.43916.paul@codesourcery.com> <20120129160105.GA10629@ponder.secretlab.ca> <20120129203606.GB11695@ponder.secretlab.ca> <4F2680C8.8040108@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4F2680C8.8040108@suse.de> Subject: Re: [Qemu-devel] [PATCH] arm: add device tree support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: qemu-devel@nongnu.org On Mon, Jan 30, 2012 at 12:36:40PM +0100, Andreas Färber wrote: > Am 29.01.2012 21:36, schrieb Grant Likely: > > On Sun, Jan 29, 2012 at 07:13:55PM +0000, Peter Maydell wrote: > >> On 29 January 2012 16:01, Grant Likely wrote: > >>> +DEF("dtb", HAS_ARG, QEMU_OPTION_dtb, \ > >>> + "-dtb file use 'file' as a device tree image\n", QEMU_ARCH_ARM) > >> > >> Needs more spaces to make it line up right in -help output: > >> Linux/Multiboot boot specific: > >> -kernel bzImage use 'bzImage' as kernel image > >> -append cmdline use 'cmdline' as kernel command line > >> -initrd file use 'file' as initial ram disk > >> -dtb file use 'file' as a device tree image > > > > Fixed. > > > > New patch below... > > > > --- > > diff --git a/Makefile.target b/Makefile.target > > index 68481a3..5e465ec 100644 > > --- a/Makefile.target > > +++ b/Makefile.target > [snip] > > Please always post patches using git-send-email and indicate the version > number as [PATCH vX] (opinions are divided whether as reply or as > top-level). The changes should be described below the commit message (or > in a cover letter). > > http://wiki.qemu.org/Contribute/SubmitAPatch > > Andreas I was really only including the new versions in my replies to shorten up the review cycle. I'll repost correctly when it looks like all comments are resolved. g.