From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rrw0K-0005PR-4A for qemu-devel@nongnu.org; Mon, 30 Jan 2012 13:31:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rrw09-00075t-7f for qemu-devel@nongnu.org; Mon, 30 Jan 2012 13:30:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54091) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rrw08-00075I-Vr for qemu-devel@nongnu.org; Mon, 30 Jan 2012 13:30:49 -0500 Date: Mon, 30 Jan 2012 16:30:34 -0200 From: Luiz Capitulino Message-ID: <20120130163034.5bdf8b12@doriath> In-Reply-To: <4F26CE3E.50801@linux.vnet.ibm.com> References: <20120126144632.GM21211@redhat.com> <4F216EAB.2000707@redhat.com> <20120126173533.0079dc98@doriath.home> <4F21DA3D.9020203@codemonkey.ws> <20120130105747.1cba8bbb@doriath> <4F26A130.10000@codemonkey.ws> <20120130124453.35fc1894@doriath> <4F26BE11.6060208@redhat.com> <4F26CE3E.50801@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: libvir-list@redhat.com, Michal Privoznik , Eric Blake , QEMU Developers On Mon, 30 Jan 2012 11:07:10 -0600 Michael Roth wrote: > On 01/30/2012 09:58 AM, Eric Blake wrote: > > On 01/30/2012 07:44 AM, Luiz Capitulino wrote: > >> I think we should do the following then: > >> > >> 1. Drop the set-support-level command > >> 2. Split the guest-suspend command into guest-suspend-ram, guest-suspend-hybrid, > >> guest-suspend-disk > >> 3. Libvirt should query for _QEMU_'s 'wakeup' command before issuing > >> the guest-suspend-ram command > >> > >> Michal, Michael, do you agree? > > > > I'm not Michal, but speaking for libvirt, this definitely sounds like > > the way to go. > > > > Questions: > > > > Should libvirt also check for 'wakeup' before attempting > > guest-suspend-hybrid? Yes. > > With guest-suspend-disk, what happens when the suspend completes? Does > > this look like a normal case of the guest powering down, which qemu then > > passes as an event to libvirt and libvirt then ends the qemu process? Yes. > > That would mean that the only difference from a normal guest shutdown is > > that on the next guest boot the guest's disk image allows to recover > > state from disk rather than booting from scratch; either way, a new qemu > > process is created to resume the guest, and qemu is doing nothing > > different in how it starts the guest (it's just that the guest itself > > does something different based on what it stored into the disk images > > before shutting down). Exactly. > > Also, I know there has been talk about a qemu-ga command to resync > > clocks after a resume from S3 and/or 'loadvm'; is this command fully in > > place yet, and is it another command that libvirt should be checking for > > prior to allowing any S3 attempts? > > > > Hi Eric, > > I'm not aware of a clock re-sync command being worked on.. are we maybe > talking about the guest-sync command qemu-ga currently has in place to > re-sync the protocol stream after a client-side timeout? I've heard some conversations about doing what Eric is saying, but I don't have any details either. Eric, do you know whom is assigned to work on that on the qemu side?