From: Richard Yang <weiyang@linux.vnet.ibm.com>
To: Mulyadi Santosa <mulyadi.santosa@gmail.com>
Cc: Richard Yang <weiyang@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Why QEMUClock is defined in qemu-timer.c?
Date: Tue, 31 Jan 2012 14:35:01 +0800 [thread overview]
Message-ID: <20120131063501.GB23981@richard> (raw)
In-Reply-To: <CAGdaadZrUwGoJdY6-CUZEksW1XRZQJoSAmVGH3n8SXL1m__FBA@mail.gmail.com>
On Tue, Jan 31, 2012 at 01:12:24PM +0700, Mulyadi Santosa wrote:
>Hi :)
>
>On Tue, Jan 31, 2012 at 12:55, Richard Yang <weiyang@linux.vnet.ibm.com> wrote:
>>
>> Hi, experts
>>
>> I am just coming to the qemu world.
>>
>> While reading the code, I am wondering why put a struct definition in the
>> c file?
>>
>> Seems there is no error in compile, while I felt it is not a proper way
>> to do it.
>
>
>maybe someone just forgot to refactor it :) I suggest to send a patch
>to do just that and let's see what everybody thinks about. I, myself
>thinks that the more readable the code is, the better
Ok, let me do it.
>
>--
>regards,
>
>Mulyadi Santosa
>Freelance Linux trainer and consultant
>
>blog: the-hydra.blogspot.com
>training: mulyaditraining.blogspot.com
--
Richard Yang
Help you, Help me
next prev parent reply other threads:[~2012-01-31 6:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 5:55 [Qemu-devel] Why QEMUClock is defined in qemu-timer.c? Richard Yang
2012-01-31 6:12 ` Mulyadi Santosa
2012-01-31 6:35 ` Richard Yang [this message]
2012-01-31 10:00 ` Dmitry Zamaruev
2012-02-01 1:33 ` Richard Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120131063501.GB23981@richard \
--to=weiyang@linux.vnet.ibm.com \
--cc=mulyadi.santosa@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).