From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56928)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weiyang@linux.vnet.ibm.com>) id 1Rs7JS-0001ai-I8
	for qemu-devel@nongnu.org; Tue, 31 Jan 2012 01:35:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weiyang@linux.vnet.ibm.com>) id 1Rs7JR-0004Y3-Fp
	for qemu-devel@nongnu.org; Tue, 31 Jan 2012 01:35:30 -0500
Received: from e23smtp02.au.ibm.com ([202.81.31.144]:39695)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weiyang@linux.vnet.ibm.com>) id 1Rs7JQ-0004Xj-Ug
	for qemu-devel@nongnu.org; Tue, 31 Jan 2012 01:35:29 -0500
Received: from /spool/local
	by e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <weiyang@linux.vnet.ibm.com>;
	Tue, 31 Jan 2012 06:19:40 +1000
Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138])
	by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q0V6UGWp2306140
	for <qemu-devel@nongnu.org>; Tue, 31 Jan 2012 17:30:19 +1100
Received: from d23av02.au.ibm.com (loopback [127.0.0.1])
	by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	q0V6Z3G5020518
	for <qemu-devel@nongnu.org>; Tue, 31 Jan 2012 17:35:05 +1100
Date: Tue, 31 Jan 2012 14:35:01 +0800
From: Richard Yang <weiyang@linux.vnet.ibm.com>
Message-ID: <20120131063501.GB23981@richard>
References: <20120131055547.GA23981@richard>
	<CAGdaadZrUwGoJdY6-CUZEksW1XRZQJoSAmVGH3n8SXL1m__FBA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGdaadZrUwGoJdY6-CUZEksW1XRZQJoSAmVGH3n8SXL1m__FBA@mail.gmail.com>
Subject: Re: [Qemu-devel] Why QEMUClock is defined in qemu-timer.c?
Reply-To: Richard Yang <weiyang@linux.vnet.ibm.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mulyadi Santosa <mulyadi.santosa@gmail.com>
Cc: Richard Yang <weiyang@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On Tue, Jan 31, 2012 at 01:12:24PM +0700, Mulyadi Santosa wrote:
>Hi :)
>
>On Tue, Jan 31, 2012 at 12:55, Richard Yang <weiyang@linux.vnet.ibm.com> wrote:
>>
>> Hi, experts
>>
>> I am just coming to the qemu world.
>>
>> While reading the code, I am wondering why put a struct definition in the
>> c file?
>>
>> Seems there is no error in compile, while I felt it is not a proper way
>> to do it.
>
>
>maybe someone just forgot to refactor it :) I suggest to send a patch
>to do just that and let's see what everybody thinks about. I, myself
>thinks that the more readable the code is, the better

Ok, let me do it.
>
>-- 
>regards,
>
>Mulyadi Santosa
>Freelance Linux trainer and consultant
>
>blog: the-hydra.blogspot.com
>training: mulyaditraining.blogspot.com

-- 
Richard Yang
Help you, Help me