From: Paul Brook <paul@codesourcery.com>
To: Alexander Graf <agraf@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Jeremy Kerr <jeremy.kerr@canonical.com>
Subject: Re: [Qemu-devel] [PATCH v2] arm: add device tree support
Date: Wed, 1 Feb 2012 01:35:30 +0000 [thread overview]
Message-ID: <201202010135.32078.paul@codesourcery.com> (raw)
In-Reply-To: <FD7610EE-454F-4E88-9CC5-0EA7D2CEEF41@suse.de>
> We could also just change machine->init() and pass the dtb in there. In a
> QOM world these would become machine device properties anyways.
>
> machine->init(ram_size, boot_devices,
> kernel_filename, kernel_cmdline, initrd_filename,
> cpu_model);
>
> Essentially we shouldn't treat -dtb any different than -kernel or -initrd.
> It's also useful for more than ARM, namely embedded ppc systems. But I can
> easily post a follow-up patch for those.
Changing machine->init means you have to touch every single board file, and
clone the exact same code for every machine that uses arm_boot.c. All of
which will be rewritten in the near future.
machine->init is a particularly suckiy interface to start with, we want to be
using it less, not more. It's not like we're going support multiple machine
instanced. At least not before machine->init is removed altogether.
Paul
next prev parent reply other threads:[~2012-02-01 1:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 0:11 [Qemu-devel] [PATCH v2] arm: add device tree support Grant Likely
2012-02-01 1:10 ` Alexander Graf
2012-02-01 1:35 ` Paul Brook [this message]
2012-02-01 1:44 ` Alexander Graf
2012-02-01 2:37 ` Anthony Liguori
2012-02-01 2:40 ` John Williams
2012-02-01 13:04 ` Anthony Liguori
2012-02-01 13:10 ` Peter Maydell
2012-02-01 13:25 ` Anthony Liguori
2012-02-01 13:32 ` Alexander Graf
2012-02-01 13:44 ` Anthony Liguori
2012-02-01 13:49 ` Alexander Graf
2012-02-01 13:52 ` Anthony Liguori
2012-02-01 13:55 ` Alexander Graf
2012-02-01 15:13 ` Anthony Liguori
2012-02-01 17:38 ` Grant Likely
2012-02-01 20:59 ` Alexander Graf
2012-02-01 2:35 ` Anthony Liguori
2012-02-22 19:42 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202010135.32078.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=agraf@suse.de \
--cc=edgar.iglesias@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=jeremy.kerr@canonical.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).