From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RsP6u-0004k7-IA for qemu-devel@nongnu.org; Tue, 31 Jan 2012 20:35:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RsP6q-0001EW-6b for qemu-devel@nongnu.org; Tue, 31 Jan 2012 20:35:44 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:48389) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RsP6q-0001Dt-1w for qemu-devel@nongnu.org; Tue, 31 Jan 2012 20:35:40 -0500 From: Paul Brook Date: Wed, 1 Feb 2012 01:35:30 +0000 References: <1328055113-30031-1-git-send-email-grant.likely@secretlab.ca> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201202010135.32078.paul@codesourcery.com> Subject: Re: [Qemu-devel] [PATCH v2] arm: add device tree support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Peter Maydell , qemu-devel@nongnu.org, Rob Herring , Grant Likely , "Edgar E. Iglesias" , Jeremy Kerr > We could also just change machine->init() and pass the dtb in there. In a > QOM world these would become machine device properties anyways. > > machine->init(ram_size, boot_devices, > kernel_filename, kernel_cmdline, initrd_filename, > cpu_model); > > Essentially we shouldn't treat -dtb any different than -kernel or -initrd. > It's also useful for more than ARM, namely embedded ppc systems. But I can > easily post a follow-up patch for those. Changing machine->init means you have to touch every single board file, and clone the exact same code for every machine that uses arm_boot.c. All of which will be rewritten in the near future. machine->init is a particularly suckiy interface to start with, we want to be using it less, not more. It's not like we're going support multiple machine instanced. At least not before machine->init is removed altogether. Paul