From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Jan Kiszka <jan.kiszka@web.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/6] qdev-property: Make bit property parsing stricter
Date: Sun, 5 Feb 2012 07:30:49 +0000 [thread overview]
Message-ID: <20120205073049.GC19189@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <4F2277D1.5070209@suse.de>
On Fri, Jan 27, 2012 at 11:09:21AM +0100, Andreas Färber wrote:
> Am 27.01.2012 08:27, schrieb Stefan Hajnoczi:
> > From: Jan Kiszka <jan.kiszka@web.de>
> >
> > By using strncasecmp, we allow for arbitrary characters after the
> > "on"/"off" string. Fix this by switching to strcasecmp.
> >
> > Reviewed-by: Andreas Färber <afaerber@suse.de>
> > Reviewed-by: Markus Armbruster <armbru@redhat.com>
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
>
> FWIW the ordering is wrong here. The tags are supposed to document the
> patch flow: The patch was first signed off by the author (Jan), then
> reviewed, then signed off by committers. Not first reviewed.
>
> No need to respin but please keep in mind for the future.
> (Yeah, did that wrong myself before.)
Okay, thanks.
Stefan
next prev parent reply other threads:[~2012-02-05 11:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 7:27 [Qemu-devel] [PULL 0/6] Trivial patches for 20 to 27 January 2012 Stefan Hajnoczi
2012-01-27 7:27 ` [Qemu-devel] [PATCH 1/6] remove #if 0 code for timers Stefan Hajnoczi
2012-01-27 7:27 ` [Qemu-devel] [PATCH 2/6] qdev-property: Make bit property parsing stricter Stefan Hajnoczi
2012-01-27 10:09 ` Andreas Färber
2012-02-05 7:30 ` Stefan Hajnoczi [this message]
2012-01-27 7:27 ` [Qemu-devel] [PATCH 3/6] e1000: Preserve link state across device reset Stefan Hajnoczi
2012-01-27 7:28 ` [Qemu-devel] [PATCH 4/6] pcnet: " Stefan Hajnoczi
2012-01-27 7:28 ` [Qemu-devel] [PATCH 5/6] ./configure: export xfs config via --{enable, disable}-xfsctl Stefan Hajnoczi
2012-01-27 17:33 ` [Qemu-devel] [PULL 0/6] Trivial patches for 20 to 27 January 2012 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120205073049.GC19189@stefanha-thinkpad.localdomain \
--to=stefanha@linux.vnet.ibm.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).