From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rv1nX-0003z2-CB for qemu-devel@nongnu.org; Wed, 08 Feb 2012 02:18:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rv1nR-0002CW-Ht for qemu-devel@nongnu.org; Wed, 08 Feb 2012 02:18:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26457) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rv1nR-0002CS-52 for qemu-devel@nongnu.org; Wed, 08 Feb 2012 02:18:29 -0500 Date: Wed, 8 Feb 2012 09:18:24 +0200 From: Gleb Natapov Message-ID: <20120208071824.GI23536@redhat.com> References: <20120203121803.6963d24f@doriath.home> <4F2C0D45.1020701@linux.vnet.ibm.com> <20120203144535.1be8a569@doriath.home> <4F2C17F9.9030103@linux.vnet.ibm.com> <20120203171627.531a42d4@doriath.home> <20120204153432.GA31653@morn.localdomain> <20120206134342.605af344@doriath.home> <20120207000942.GA23819@morn.localdomain> <20120207084439.GA23536@redhat.com> <20120208003534.GA8786@morn.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120208003534.GA8786@morn.localdomain> Subject: Re: [Qemu-devel] [PATCH v2 0/8] qemu-ga: add support for Windows List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin O'Connor Cc: ghammer@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, Michael Roth , Luiz Capitulino On Tue, Feb 07, 2012 at 07:35:34PM -0500, Kevin O'Connor wrote: > > > In any case, I don't think this was addressed. Gerd published a patch > > > that can address this in qemu: > > > http://www.seabios.org/pipermail/seabios/2012-January/002944.html > > > > > Strictly speaking the patch is incorrect since it introduces the file > > for all architectures, but I do not think qemu is the right place to > > tune SeaBIOS defaults. I propose this patch instead: > [...] > > // Load some config settings that impact VGA. > > EnforceChecksum = romfile_loadint("etc/optionroms-checksum", 1); > > - S3ResumeVgaInit = romfile_loadint("etc/s3-resume-vga-init", 0); > > + S3ResumeVgaInit = romfile_loadint("etc/s3-resume-vga-init", !CONFIG_COREBOOT); > > ScreenAndDebug = romfile_loadint("etc/screen-and-debug", 1); > > I'm concerned about the VGA passthrough case. (I know that's not > common and has other issues, but I also know several people have been > working with it.) As near as I can tell, running the VGA rom on S3 > resume has as much chance of breaking things as helping things. It's > fine for the cirrus/bochsvga vgaroms that are totally under our > control, but it'd be an open guess for any third-party code. (Again, > if someone has documentation to the contrary please let me know.) > VGA passthrough does not work with QEMU without code changes. Whoever works on it will have to provide etc/s3-resume-vga-init file with appropriate value. My patch above does not remove run time selection, it only changes the default. > So, compiling this into SeaBIOS doesn't seems like the right choice to > me. > It is still run time selectable. I think it is best of both worlds. -- Gleb.