From: Paul Brook <paul@codesourcery.com>
To: "Peter A. G. Crosthwaite" <peter.crosthwaite@petalogix.com>
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com,
qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition
Date: Wed, 8 Feb 2012 09:06:39 +0000 [thread overview]
Message-ID: <201202080906.39664.paul@codesourcery.com> (raw)
In-Reply-To: <1328687721-16030-1-git-send-email-peter.crosthwaite@petalogix.com>
> diff --git a/hw/versatilepb.c b/hw/versatilepb.c
> index 6e28e78..e42d845 100644
> --- a/hw/versatilepb.c
> +++ b/hw/versatilepb.c
> @@ -313,12 +313,14 @@ static void versatile_init(ram_addr_t ram_size,
> /* 0x101f3000 UART2. */
> /* 0x101f4000 SSPI. */
>
> - versatile_binfo.ram_size = ram_size;
> - versatile_binfo.kernel_filename = kernel_filename;
> - versatile_binfo.kernel_cmdline = kernel_cmdline;
> - versatile_binfo.initrd_filename = initrd_filename;
> - versatile_binfo.board_id = board_id;
> - arm_load_kernel(env, &versatile_binfo);
> + if (kernel_filename) {
> + versatile_binfo.ram_size = ram_size;
> + versatile_binfo.kernel_filename = kernel_filename;
> + versatile_binfo.kernel_cmdline = kernel_cmdline;
> + versatile_binfo.initrd_filename = initrd_filename;
> + versatile_binfo.board_id = board_id;
> + arm_load_kernel(env, &versatile_binfo);
> + }
> }
This should be using the new object you just added.
You also need to fix all the other uses of arm_load_kernel.
Paul
next prev parent reply other threads:[~2012-02-08 9:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 7:55 [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition Peter A. G. Crosthwaite
2012-02-08 9:06 ` Paul Brook [this message]
2012-02-08 10:11 ` Peter Crosthwaite
2012-02-08 10:44 ` Paul Brook
2012-02-08 11:10 ` Peter Crosthwaite
2012-02-08 11:39 ` Paul Brook
2012-02-08 11:59 ` Peter Crosthwaite
2012-02-08 12:27 ` Paul Brook
2012-02-08 12:41 ` Alexander Graf
2012-02-08 13:04 ` Peter Crosthwaite
2012-02-08 13:10 ` Alexander Graf
2012-02-08 13:30 ` Peter Crosthwaite
2012-02-08 13:35 ` Alexander Graf
2012-02-08 14:05 ` Peter Crosthwaite
2012-02-08 14:17 ` Alexander Graf
2012-02-08 14:20 ` Paul Brook
2012-02-08 14:39 ` Peter Crosthwaite
2012-02-08 14:56 ` Paul Brook
2012-02-08 15:14 ` Peter Crosthwaite
2012-02-08 15:57 ` Paul Brook
2012-02-08 16:03 ` Peter Crosthwaite
2012-02-08 16:15 ` Paul Brook
2012-02-08 16:35 ` Anthony Liguori
2012-02-09 1:22 ` Peter Crosthwaite
2012-02-09 12:03 ` Paul Brook
2012-02-08 16:20 ` Anthony Liguori
2012-02-08 13:47 ` Anthony Liguori
2012-02-20 19:43 ` Peter Maydell
2012-02-20 19:51 ` Andreas Färber
2012-02-20 19:56 ` Peter Maydell
2012-02-21 9:15 ` Peter Crosthwaite
2012-02-21 10:20 ` Peter Maydell
2012-02-08 13:41 ` Anthony Liguori
2012-02-09 13:22 ` Andreas Färber
2012-02-10 2:11 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202080906.39664.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=peter.crosthwaite@petalogix.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).