From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rv4YS-0002o5-L6 for qemu-devel@nongnu.org; Wed, 08 Feb 2012 05:15:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rv4YK-0007j7-3G for qemu-devel@nongnu.org; Wed, 08 Feb 2012 05:15:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53352) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rv4YJ-0007ia-SI for qemu-devel@nongnu.org; Wed, 08 Feb 2012 05:15:04 -0500 Date: Wed, 8 Feb 2012 10:14:55 +0000 From: "Daniel P. Berrange" Message-ID: <20120208101454.GA13005@redhat.com> References: <1328647446-5452-1-git-send-email-meadori@codesourcery.com> <87liodivvw.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87liodivvw.fsf@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v1 0/1] Allow the building of VirtFS to be disabled Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: aliguori@us.ibm.com, Meador Inge , qemu-devel@nongnu.org On Wed, Feb 08, 2012 at 01:45:15PM +0530, Aneesh Kumar K.V wrote: > On Tue, 7 Feb 2012 14:44:05 -0600, Meador Inge wrote: > > There have been reports [1, 2] where folks have had issues building > > VirtFS and the virtio backend on older systems. I personally saw > > problems due to the use of features (struct statfs f_frsize field, > > fdopendir, O_NOATIME) in this code that are not available on much older > > Linux systems. Given, the system I ran into this on is ancient (RH8 sysroot), > > but I still need to build QEMU on it nonetheless. [snip] > I like the patch because it help to get qemu build on platforms where > the build failures are only due to virtfs. VirtFS do depend on some of > the recent linux APIs, so sometime we do break build on old Linux > distros. Allowing build to be disabled is a fine goal in itself. I think someone should still fix the code to be more portable though. f_frsize is a non-standardized field in 'struct stat', so its usage should be made conditional. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|