From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rv6eR-0004we-3V for qemu-devel@nongnu.org; Wed, 08 Feb 2012 07:29:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rv6eP-0002Ji-DL for qemu-devel@nongnu.org; Wed, 08 Feb 2012 07:29:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rv6eP-0002JS-5l for qemu-devel@nongnu.org; Wed, 08 Feb 2012 07:29:29 -0500 Date: Wed, 8 Feb 2012 10:29:24 -0200 From: Luiz Capitulino Message-ID: <20120208102924.5d8fa197@doriath.home> In-Reply-To: <4F30EB02.6080605@redhat.com> References: <1328342577-25732-1-git-send-email-pbonzini@redhat.com> <1328342577-25732-7-git-send-email-pbonzini@redhat.com> <4F2FE0D5.9020407@codemonkey.ws> <4F30EB02.6080605@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 06/27] qom: add QObject-based property get/set wrappers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Tue, 07 Feb 2012 10:12:34 +0100 Paolo Bonzini wrote: > On 02/06/2012 03:16 PM, Anthony Liguori wrote: > > > >> Move the creation of QmpInputVisitor and QmpOutputVisitor from > >> qmp.c to qom/object.c, since it's the only practical way to access > >> object properties. > >> > >> Signed-off-by: Paolo Bonzini > > > > Reluctantly-Reviewed-by: Anthony Liguori > > Fair enough, thanks very much. :) > > > As long as we keep this isolated such that it's easy to remove. At some > > point, we need to remove all usage of QObject in the tree and replace it > > with GVariant. > > Agreed, we'll revisit after Luiz completes QAPI. Commands are not far away. Events are still missing, although they could be converted along with the introduction of GVariant.