From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rv50i-00080F-Ie for qemu-devel@nongnu.org; Wed, 08 Feb 2012 05:44:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rv50e-0004rc-Cy for qemu-devel@nongnu.org; Wed, 08 Feb 2012 05:44:24 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:53791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rv50e-0004rR-8X for qemu-devel@nongnu.org; Wed, 08 Feb 2012 05:44:20 -0500 From: Paul Brook Date: Wed, 8 Feb 2012 10:44:13 +0000 References: <1328687721-16030-1-git-send-email-peter.crosthwaite@petalogix.com> <201202080906.39664.paul@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Message-Id: <201202081044.14202.paul@codesourcery.com> Subject: Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org, agraf@suse.de > > > + arm_load_kernel(env, &versatile_binfo); > > > + } > > > > > > } > > > > This should be using the new object you just added. > > Yes I agree. There is another question tho that if this approach is to be > considered, should this call to arm_load_kernel be removed from the machine > model altogether? Only reason to keep it would be backwards compatibility > for the original command line format. I think we want the -kernel commandline option, butI'mnot attached to a particular implementation. Once we have an arm_linux_loader device then arm_load_kernel should go away, or at least be a private implementation detail of arm_linux_loader. Who creates the arm_linux_loader object (common code or board init function), and how we arrange for it to have the right properties (filename from -kernel, board ID from specific machine) is something I haven't entirely figured out. I suspect we want to replace the arm_load_kernel call with an arm_linux_loader device with appropriate properties. We should have some mechanism for the user to override/augment those properties (e.g. overriding the FDT file). I don't know if that functionality actually exists, or if what we have is particularly well thought out. Ideally the -kernel commandline would just be shorthand for setting/overriding the filename property on that device. The machine->init arguments are removed. That's probably going to need wider coordination with other arches. Paul