Re: [Qemu-devel] [PATCH v2 0/8] qemu-ga: add support for Windows

[Kevin O'Connor <kevin@koconnor.net>]

On Wed, Feb 08, 2012 at 09:18:24AM +0200, Gleb Natapov wrote:
> On Tue, Feb 07, 2012 at 07:35:34PM -0500, Kevin O'Connor wrote:
> > I'm concerned about the VGA passthrough case.  (I know that's not
> > common and has other issues, but I also know several people have been
> > working with it.)  As near as I can tell, running the VGA rom on S3
> > resume has as much chance of breaking things as helping things.  It's
> > fine for the cirrus/bochsvga vgaroms that are totally under our
> > control, but it'd be an open guess for any third-party code.  (Again,
> > if someone has documentation to the contrary please let me know.)
> > 
> VGA passthrough does not work with QEMU without code changes. Whoever
> works on it will have to provide etc/s3-resume-vga-init file with
> appropriate value. My patch above does not remove run time selection, it
> only changes the default.

True.

I view running the vgabios on s3 a hack and think an explicit "please
apply hack" flag is nicer than the inverse.

However, it's clear this hack helps the majority of qemu/kvm users.
So, I'm okay with changing the default.  It is a change of default
though (upstream kvm/qemu has never run the vgabios on s3 resume
before).  So, we need to make sure there's proper notice of the change
and assuming no objection I'll go forward with it.

-Kevin