From: Stefan Hajnoczi <stefanha@gmail.com>
To: Ulrich Hecht <uli@suse.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: fail execve() if env/args too big
Date: Thu, 9 Feb 2012 08:30:13 +0000 [thread overview]
Message-ID: <20120209083013.GA30974@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1328010196-32134-1-git-send-email-uli@suse.de>
On Tue, Jan 31, 2012 at 12:43:16PM +0100, Ulrich Hecht wrote:
> If the host's page size is equal to or smaller than the target's, native
> execve() will fail appropriately with E2BIG if called with too big an
> environment for the target to handle. It may falsely succeed, however, if
> the host's page size is bigger, and feed the executed target process an
> environment that is too big for it to handle, at which point QEMU barfs and
> exits, confusing procmail's autoconf script and causing the build to fail.
>
> This patch makes sure that execve() will return E2BIG if the environment is
> too large for the target.
>
> Signed-off-by: Ulrich Hecht <uli@suse.de>
> ---
> linux-user/syscall.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
prev parent reply other threads:[~2012-02-09 9:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 11:43 [Qemu-devel] [PATCH] linux-user: fail execve() if env/args too big Ulrich Hecht
2012-02-09 8:30 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120209083013.GA30974@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=uli@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).