From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvQD0-0007Ol-7R for qemu-devel@nongnu.org; Thu, 09 Feb 2012 04:22:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvQCu-0007iU-CW for qemu-devel@nongnu.org; Thu, 09 Feb 2012 04:22:30 -0500 Date: Thu, 9 Feb 2012 08:30:13 +0000 From: Stefan Hajnoczi Message-ID: <20120209083013.GA30974@stefanha-thinkpad.localdomain> References: <1328010196-32134-1-git-send-email-uli@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1328010196-32134-1-git-send-email-uli@suse.de> Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: fail execve() if env/args too big List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ulrich Hecht Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On Tue, Jan 31, 2012 at 12:43:16PM +0100, Ulrich Hecht wrote: > If the host's page size is equal to or smaller than the target's, native > execve() will fail appropriately with E2BIG if called with too big an > environment for the target to handle. It may falsely succeed, however, if > the host's page size is bigger, and feed the executed target process an > environment that is too big for it to handle, at which point QEMU barfs and > exits, confusing procmail's autoconf script and causing the build to fail. > > This patch makes sure that execve() will return E2BIG if the environment is > too large for the target. > > Signed-off-by: Ulrich Hecht > --- > linux-user/syscall.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan