From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvQmU-0000pl-R1 for qemu-devel@nongnu.org; Thu, 09 Feb 2012 04:59:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvQmQ-0006U3-06 for qemu-devel@nongnu.org; Thu, 09 Feb 2012 04:59:10 -0500 Received: from ozlabs.org ([203.10.76.45]:42468) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvQmP-0006TH-Ea for qemu-devel@nongnu.org; Thu, 09 Feb 2012 04:59:05 -0500 Date: Thu, 9 Feb 2012 20:58:23 +1100 From: David Gibson Message-ID: <20120209095823.GE22832@truffala.fritz.box> References: <1328761361-23119-1-git-send-email-david@gibson.dropbear.id.au> <4F338411.20408@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0F1p//8PRICkK4MW" Content-Disposition: inline In-Reply-To: <4F338411.20408@web.de> Subject: Re: [Qemu-devel] [PATCH] ioctl() numbers are unsigned (the man page lies) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: mtosatti@redhat.com, avi@redhat.com, qemu-devel@nongnu.org --0F1p//8PRICkK4MW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 09, 2012 at 09:30:09AM +0100, Jan Kiszka wrote: > Looks like the subject would warmly welcome a "kvm:" tag. >=20 > On 2012-02-09 05:22, David Gibson wrote: [snip] >=20 > What about naming the problem instead: >=20 > /* Comparison with IOCTL macros on 32-bit hosts requires unsigned. */ Just once, it would be nice to post something to this list and get a substantive comment _before_ the bitching about minutiae. Oh, and it's not just 32-bit hosts, it's anywhere sizeof(int)=3D=3D4, which includes ppc64 amongst other 64-bit hosts. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --0F1p//8PRICkK4MW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8zmL8ACgkQaILKxv3ab8YfqwCfRHMAryLX/wLbHpJPi05uqO5z qX4An149RIgIjKt7Toa+t+c4CUU28KdY =bKIz -----END PGP SIGNATURE----- --0F1p//8PRICkK4MW--