* [Qemu-devel] [TRIVIAL] virtio_cleanup(): Remove unneeded g_free() parameter check
@ 2012-02-09 13:29 Luiz Capitulino
2012-02-09 15:28 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
0 siblings, 1 reply; 3+ messages in thread
From: Luiz Capitulino @ 2012-02-09 13:29 UTC (permalink / raw)
To: qemu-trivial; +Cc: qemu-devel
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
hw/virtio.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/virtio.c b/hw/virtio.c
index 74cc038..064aecf 100644
--- a/hw/virtio.c
+++ b/hw/virtio.c
@@ -845,8 +845,7 @@ int virtio_load(VirtIODevice *vdev, QEMUFile *f)
void virtio_cleanup(VirtIODevice *vdev)
{
qemu_del_vm_change_state_handler(vdev->vmstate);
- if (vdev->config)
- g_free(vdev->config);
+ g_free(vdev->config);
g_free(vdev->vq);
g_free(vdev);
}
--
1.7.9.111.gf3fb0.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [TRIVIAL] virtio_cleanup(): Remove unneeded g_free() parameter check
2012-02-09 13:29 [Qemu-devel] [TRIVIAL] virtio_cleanup(): Remove unneeded g_free() parameter check Luiz Capitulino
@ 2012-02-09 15:28 ` Stefan Hajnoczi
2012-02-09 15:48 ` Luiz Capitulino
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Hajnoczi @ 2012-02-09 15:28 UTC (permalink / raw)
To: Luiz Capitulino; +Cc: qemu-trivial, qemu-devel
On Thu, Feb 09, 2012 at 11:29:42AM -0200, Luiz Capitulino wrote:
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
> hw/virtio.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
Tweaked commit message to be more conventional with "virtio: Remove
unneeded g_free() check in virtio_cleanup()".
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [TRIVIAL] virtio_cleanup(): Remove unneeded g_free() parameter check
2012-02-09 15:28 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
@ 2012-02-09 15:48 ` Luiz Capitulino
0 siblings, 0 replies; 3+ messages in thread
From: Luiz Capitulino @ 2012-02-09 15:48 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: qemu-trivial, qemu-devel
On Thu, 9 Feb 2012 15:28:58 +0000
Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Thu, Feb 09, 2012 at 11:29:42AM -0200, Luiz Capitulino wrote:
> >
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> > hw/virtio.c | 3 +--
> > 1 files changed, 1 insertions(+), 2 deletions(-)
>
> Tweaked commit message to be more conventional with "virtio: Remove
> unneeded g_free() check in virtio_cleanup()".
Thanks.
>
> Thanks, applied to the trivial patches tree:
> https://github.com/stefanha/qemu/commits/trivial-patches
>
> Stefan
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-09 15:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-09 13:29 [Qemu-devel] [TRIVIAL] virtio_cleanup(): Remove unneeded g_free() parameter check Luiz Capitulino
2012-02-09 15:28 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-02-09 15:48 ` Luiz Capitulino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).