From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvSnA-0004Lq-Uv for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:08:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvSn5-0002Wz-9A for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:08:00 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:62962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvSn5-0002Wu-4t for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:07:55 -0500 From: Paul Brook Date: Thu, 9 Feb 2012 12:07:50 +0000 References: <1328761361-23119-1-git-send-email-david@gibson.dropbear.id.au> <20120209095823.GE22832@truffala.fritz.box> <4F339AC1.6080700@web.de> In-Reply-To: <4F339AC1.6080700@web.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Message-Id: <201202091207.51350.paul@codesourcery.com> Subject: Re: [Qemu-devel] [PATCH] ioctl() numbers are unsigned (the man page lies) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mtosatti@redhat.com, Jan Kiszka , avi@redhat.com > >> What about naming the problem instead: > >> > >> /* Comparison with IOCTL macros on 32-bit hosts requires unsigned. */ > > > > Just once, it would be nice to post something to this list and get a > > substantive comment _before_ the bitching about minutiae. > > > > Oh, and it's not just 32-bit hosts, it's anywhere sizeof(int)==4, > > which includes ppc64 amongst other 64-bit hosts. > > Then state "if int is 32 bits". The comment is unfortunately not helpful > without the commit log. Int is 32 bits on every host we're ever likey to care about, so clearly there's something else going on. Paul