From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvSut-0005j5-1Z for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:16:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvSur-0004BU-JJ for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:15:58 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:63705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvSur-0004BG-5a for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:15:57 -0500 From: Paul Brook Date: Thu, 9 Feb 2012 12:15:51 +0000 References: <1328767876-357-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1328767876-357-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Message-Id: <201202091215.52550.paul@codesourcery.com> Subject: Re: [Qemu-devel] [PATCH] ARM devboards: Set arm_sysctl properties before init, not after List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Anthony Liguori , Evgeny Voevodin , patches@linaro.org, Dmitry Solodkiy , pbonzini@redhat.com > The ARM devboard models (vexpress-a9, realview, versatilepb, etc) > were accidentally trying to set one of the arm_sysctl properties > after device init. This has now become a fatal error; set the property > before device init where it should be done instead. > > Signed-off-by: Peter Maydell > --- > If somebody would like to commit this simple patch quickly that would > probably be a good idea since these models are otherwise totally broken... Done. Paul