From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvTFm-0004XD-FK for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:37:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvTFi-0000QV-A5 for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:37:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:25599) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvTFi-0000QO-0z for qemu-devel@nongnu.org; Thu, 09 Feb 2012 07:37:30 -0500 Date: Thu, 9 Feb 2012 14:37:25 +0200 From: Gleb Natapov Message-ID: <20120209123725.GK18866@redhat.com> References: <1328698819-31269-1-git-send-email-kraxel@redhat.com> <1328698819-31269-2-git-send-email-kraxel@redhat.com> <20120209084816.GB18866@redhat.com> <4F33A3C1.1080108@redhat.com> <20120209111928.GH18866@redhat.com> <4F33B5E7.7070502@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F33B5E7.7070502@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 1/6] suspend: add infrastructure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org On Thu, Feb 09, 2012 at 01:02:47PM +0100, Gerd Hoffmann wrote: > On 02/09/12 12:19, Gleb Natapov wrote: > > On Thu, Feb 09, 2012 at 11:45:21AM +0100, Gerd Hoffmann wrote: > >> On 02/09/12 09:48, Gleb Natapov wrote: > >>> On Wed, Feb 08, 2012 at 12:00:14PM +0100, Gerd Hoffmann wrote: > >>>> * qemu_system_wakeup_request is supposed to be called on events which > >>>> should wake up the guest. > >>>> > >>> qemu_system_wakeup_request() should get wakeup source as a parameter. > >>> There are ways to report it to a guest. > >> > >> Can we do that incrementally, when we actually implement the guest > >> reporting? > >> > > What do you mean by "when we actually implement the guest > > reporting"? The guest reporting is part of ACPI spec and implemented > > by all relevant guests. I think that adding wakeup source parameter to > > qemu_system_wakeup_request() and reporting RTC_STS and PWRBTN_STS should > > not complicate your patch series to much. I agree that DSDT magic required > > by other devices can wait for later. > > Incremental patch (just infrastructure, no acpi windup yet) attached. > Something like this? > We need to give ACPI ability to prevent wakeup. So, for instance, if RTC alarm calls wakeup but ACPI detects that RTC_EN is cleared it can prevent it. > cheers, > Gerd > commit 78fbd17ddc98a2e96e05db62afbe3a69c5fad5e5 > Author: Gerd Hoffmann > Date: Thu Feb 9 12:52:48 2012 +0100 > > reason: infra > > diff --git a/sysemu.h b/sysemu.h > index 3b9d7f5..e7060aa 100644 > --- a/sysemu.h > +++ b/sysemu.h > @@ -38,10 +38,16 @@ void vm_start(void); > void vm_stop(RunState state); > void vm_stop_force_state(RunState state); > > +typedef enum WakeupReason { > + QEMU_WAKEUP_REASON_OTHER = 0, > + QEMU_WAKEUP_REASON_RTC, > +} WakeupReason; > + > void qemu_system_reset_request(void); > void qemu_system_suspend_request(void); > void qemu_register_suspend_notifier(Notifier *notifier); > -void qemu_system_wakeup_request(void); > +void qemu_system_wakeup_request(WakeupReason reason); > +void qemu_register_wakeup_notifier(Notifier *notifier); > void qemu_system_shutdown_request(void); > void qemu_system_powerdown_request(void); > void qemu_system_debug_request(void); > diff --git a/vl.c b/vl.c > index 822fd58..17d4b72 100644 > --- a/vl.c > +++ b/vl.c > @@ -1286,6 +1286,8 @@ static int debug_requested; > static bool is_suspended; > static NotifierList suspend_notifiers = > NOTIFIER_LIST_INITIALIZER(suspend_notifiers); > +static NotifierList wakeup_notifiers = > + NOTIFIER_LIST_INITIALIZER(wakeup_notifiers); > static RunState vmstop_requested = RUN_STATE_MAX; > > int qemu_shutdown_requested_get(void) > @@ -1416,16 +1418,22 @@ void qemu_register_suspend_notifier(Notifier *notifier) > notifier_list_add(&suspend_notifiers, notifier); > } > > -void qemu_system_wakeup_request(void) > +void qemu_system_wakeup_request(WakeupReason reason) > { > if (!is_suspended) { > return; > } > + notifier_list_notify(&wakeup_notifiers, &reason); > reset_requested = 1; > qemu_notify_event(); > is_suspended = false; > } > > +void qemu_register_wakeup_notifier(Notifier *notifier) > +{ > + notifier_list_add(&wakeup_notifiers, notifier); > +} > + > void qemu_system_killed(int signal, pid_t pid) > { > shutdown_signal = signal; -- Gleb.