From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46891)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Paul_Brook@mentor.com>) id 1RvTtA-0000pf-Sp
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 08:18:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Paul_Brook@mentor.com>) id 1RvTt6-00031x-Iy
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 08:18:16 -0500
Received: from relay1.mentorg.com ([192.94.38.131]:40199)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Paul_Brook@mentor.com>) id 1RvTt6-00031h-ED
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 08:18:12 -0500
From: Paul Brook <paul@codesourcery.com>
Date: Thu, 9 Feb 2012 13:18:03 +0000
References: <1328767876-357-1-git-send-email-peter.maydell@linaro.org>
	<201202091215.52550.paul@codesourcery.com>
	<4F33BD5F.3040901@suse.de>
In-Reply-To: <4F33BD5F.3040901@suse.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201202091318.04031.paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] ARM devboards: Set arm_sysctl properties
	before init, not after
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?utf-8?q?F=C3=A4rber?= <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Evgeny Voevodin <e.voevodin@samsung.com>, patches@linaro.org, qemu-devel@nongnu.org, Dmitry Solodkiy <d.solodkiy@samsung.com>, pbonzini@redhat.com

> Am 09.02.2012 13:15, schrieb Paul Brook:
> >> The ARM devboard models (vexpress-a9, realview, versatilepb, etc)
> >> were accidentally trying to set one of the arm_sysctl properties
> >> after device init. This has now become a fatal error; set the property
> >> before device init where it should be done instead.
> >> 
> >> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> >> ---
> >> If somebody would like to commit this simple patch quickly that would
> >> probably be a good idea since these models are otherwise totally
> >> broken...
> > 
> > Done.
> 
> Your commit should've contained Paolo's Reviewed-by tag after Peter's
> SoB,

Ok.

> and you as committer didn't sign it off either.

Ah, I thought SoB was only relevant if I'd actually touched the patch.

Paul