Re: [Qemu-devel] [PATCH] ioctl() numbers are unsigned (the man page lies)

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]

On Thu, Feb 09, 2012 at 11:06:57AM +0100, Jan Kiszka wrote:
> On 2012-02-09 10:58, David Gibson wrote:
> > On Thu, Feb 09, 2012 at 09:30:09AM +0100, Jan Kiszka wrote:
> >> Looks like the subject would warmly welcome a "kvm:" tag.
> >>
> >> On 2012-02-09 05:22, David Gibson wrote:
> > [snip]
> >>
> >> What about naming the problem instead:
> >>
> >> /* Comparison with IOCTL macros on 32-bit hosts requires unsigned. */
> > 
> > Just once, it would be nice to post something to this list and get a
> > substantive comment _before_ the bitching about minutiae.
> > 
> > Oh, and it's not just 32-bit hosts, it's anywhere sizeof(int)==4,
> > which includes ppc64 amongst other 64-bit hosts.
> 
> Then state "if int is 32 bits". The comment is unfortunately not helpful
> without the commit log.

It'd also be nice if people didn't drop me from the CC list on my own
patches.

I have resent the patch with a revised summary.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]