From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvkEe-0000wi-QZ for qemu-devel@nongnu.org; Fri, 10 Feb 2012 01:45:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvkEd-0007XK-Io for qemu-devel@nongnu.org; Fri, 10 Feb 2012 01:45:32 -0500 Received: from ozlabs.org ([203.10.76.45]:45452) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvkEc-0007XA-Qq for qemu-devel@nongnu.org; Fri, 10 Feb 2012 01:45:31 -0500 Date: Fri, 10 Feb 2012 17:43:39 +1100 From: David Gibson Message-ID: <20120210064339.GH10536@truffala.fritz.box> References: <1328761361-23119-1-git-send-email-david@gibson.dropbear.id.au> <4F338411.20408@web.de> <20120209095823.GE22832@truffala.fritz.box> <4F339AC1.6080700@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SUOF0GtieIMvvwua" Content-Disposition: inline In-Reply-To: <4F339AC1.6080700@web.de> Subject: Re: [Qemu-devel] [PATCH] ioctl() numbers are unsigned (the man page lies) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: mtosatti@redhat.com, avi@redhat.com, qemu-devel@nongnu.org --SUOF0GtieIMvvwua Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 09, 2012 at 11:06:57AM +0100, Jan Kiszka wrote: > On 2012-02-09 10:58, David Gibson wrote: > > On Thu, Feb 09, 2012 at 09:30:09AM +0100, Jan Kiszka wrote: > >> Looks like the subject would warmly welcome a "kvm:" tag. > >> > >> On 2012-02-09 05:22, David Gibson wrote: > > [snip] > >> > >> What about naming the problem instead: > >> > >> /* Comparison with IOCTL macros on 32-bit hosts requires unsigned. */ > >=20 > > Just once, it would be nice to post something to this list and get a > > substantive comment _before_ the bitching about minutiae. > >=20 > > Oh, and it's not just 32-bit hosts, it's anywhere sizeof(int)=3D=3D4, > > which includes ppc64 amongst other 64-bit hosts. >=20 > Then state "if int is 32 bits". The comment is unfortunately not helpful > without the commit log. It'd also be nice if people didn't drop me from the CC list on my own patches. I have resent the patch with a revised summary. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --SUOF0GtieIMvvwua Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk80vJsACgkQaILKxv3ab8bZVACfSnn8BzQrhJt989OBrOw9W9fA 1zkAnijDX+iK39yqXis+lb4JbMWSgv0m =VSoz -----END PGP SIGNATURE----- --SUOF0GtieIMvvwua--