qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Lluís Vilanova" <vilanova@ac.upc.edu>
To: qemu-devel@nongnu.org
Cc: stefanha@gmail.com, harsh@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v3 02/11] trace: [tracetool] Do not rebuild event list in backend code
Date: Fri, 10 Feb 2012 12:49:01 +0100	[thread overview]
Message-ID: <20120210114901.5104.60007.stgit@ginnungagap.bsc.es> (raw)
In-Reply-To: <20120210114849.5104.63589.stgit@ginnungagap.bsc.es>

Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
---
 scripts/tracetool.py |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/scripts/tracetool.py b/scripts/tracetool.py
index f0d7e1e..7042728 100755
--- a/scripts/tracetool.py
+++ b/scripts/tracetool.py
@@ -171,15 +171,14 @@ def simple_c(events):
     print
     print 'TraceEvent trace_list[] = {'
     print
-    eventlist = list(events)
-    for event in eventlist:
+    for event in events:
         print '{.tp_name = "%(name)s", .state=0},' % {
     'name': event.name
 }
         print
     print '};'
     print
-    for event in eventlist:
+    for event in events:
         argc = event.argc
         print '''void trace_%(name)s(%(args)s)
 {
@@ -311,8 +310,7 @@ def ust_c(events):
 #undef inline
 #undef wmb
 #include "trace.h"'''
-    eventlist = list(events)
-    for event in eventlist:
+    for event in events:
         argnames = event.argnames
         if event.argc > 0:
             argnames = ', ' + event.argnames
@@ -344,7 +342,7 @@ static void ust_%(name)s_probe(%(args)s)
     print '''
 static void __attribute__((constructor)) trace_init(void)
 {'''
-    for event in eventlist:
+    for event in events:
         print '    register_trace_ust_%(name)s(ust_%(name)s_probe);' % {
     'name': event.name
 }
@@ -510,14 +508,16 @@ class Event(object):
 
 # Generator that yields Event objects given a trace-events file object
 def read_events(fobj):
+    res = []
     event_num = 0
     for line in fobj:
         if not line.strip():
             continue
         if line.lstrip().startswith('#'):
 	    continue
-	yield Event(event_num, line)
+	res.append(Event(event_num, line))
 	event_num += 1
+    return res
 
 backend = ""
 output = ""

  parent reply	other threads:[~2012-02-10 11:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-10 11:48 [Qemu-devel] [PATCH v3 00/11] tracetool: Improvements for future expansion Lluís Vilanova
2012-02-10 11:48 ` [Qemu-devel] [PATCH v3 01/11] [trivial] Fix a compiler warning Lluís Vilanova
2012-02-10 11:49 ` Lluís Vilanova [this message]
2012-02-10 11:49 ` [Qemu-devel] [PATCH v3 03/11] trace: [tracetool] Simplify event line parsing Lluís Vilanova
2012-02-10 11:53   ` Harsh Bora
2012-02-10 11:49 ` [Qemu-devel] [PATCH v3 04/11] trace: [ŧracetool] Do not precompute the event number Lluís Vilanova
2012-02-10 11:49 ` [Qemu-devel] [PATCH v3 05/11] trace: [tracetool] Add support for event properties Lluís Vilanova
2012-02-10 11:49 ` [Qemu-devel] [PATCH v3 06/11] trace: [tracetool] Process the "disable" event property Lluís Vilanova
2012-02-10 11:49 ` [Qemu-devel] [PATCH v3 07/11] trace: [tracetool] Rewrite event argument parsing Lluís Vilanova
2012-02-10 11:49 ` [Qemu-devel] [PATCH v3 08/11] trace: [tracetool] Make format-specific code optional and with access to event information Lluís Vilanova
2012-02-10 11:49 ` [Qemu-devel] [PATCH v3 09/11] trace: [tracetool] Automatically establish available backends and formats Lluís Vilanova
2012-02-10 11:49 ` [Qemu-devel] [PATCH v3 10/11] trace: Provide a per-event status define for conditional compilation Lluís Vilanova
2012-02-10 11:49 ` [Qemu-devel] [PATCH v3 11/11] trace: [tracetool] Add error-reporting functions Lluís Vilanova

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120210114901.5104.60007.stgit@ginnungagap.bsc.es \
    --to=vilanova@ac.upc.edu \
    --cc=harsh@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).