From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43231)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1RvuSJ-00051i-B6
	for qemu-devel@nongnu.org; Fri, 10 Feb 2012 12:40:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1RvuSE-0001VI-Oh
	for qemu-devel@nongnu.org; Fri, 10 Feb 2012 12:40:19 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38320)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1RvuSE-0001VB-5t
	for qemu-devel@nongnu.org; Fri, 10 Feb 2012 12:40:14 -0500
Date: Fri, 10 Feb 2012 15:40:10 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120210154010.3bc184dd@doriath.home>
In-Reply-To: <4F34FFCD.8040603@redhat.com>
References: <1328625520-19217-1-git-send-email-berrange@redhat.com>
	<4F34FFCD.8040603@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] Add SPICE support to add_client monitor
	command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On Fri, 10 Feb 2012 12:30:21 +0100
Gerd Hoffmann <kraxel@redhat.com> wrote:

> On 02/07/12 15:38, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange@redhat.com>
> > 
> > This is a followup to
> > 
> >   http://patchwork.ozlabs.org/patch/121004/
> > 
> > With the acceptance of some new APIs to libspice-server.so it
> > is possible to add support for SPICE to the 'add_client'
> > monitor command, bringing parity with VNC. Since SPICE can
> > use TLS or plain connections, the command also gains a new
> > 'tls' parameter to specify whether TLS should be attempted
> > on the injected client sockets.
> > 
> > This new feature is only enabled if building against a
> > libspice-server >= 0.10.1
> > 
> > * qmp-commands.hx: Add 'tls' parameter & missing doc for
> >   'skipauth' parameter
> > * monitor.c: Wire up SPICE for 'add_client' command
> > * ui/qemu-spice.h, ui/spice-core.c: Add qemu_spice_display_add_client
> >   API to wire up from monitor
> 
> Spice bits are sane, the monitor bits look good to me too.
> 
> Luiz?  Can you have a look at the monitor bits?  If you ack I'll go
> queue it up for the next spice update.  Or you can just grab it and
> merge via qmp tree.

Reviewed. Will need a respin. Will ack v3 and you merge it through the
spice queue.