From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvtyF-0004Sg-GO for qemu-devel@nongnu.org; Fri, 10 Feb 2012 12:09:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rvty9-00036N-SX for qemu-devel@nongnu.org; Fri, 10 Feb 2012 12:09:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:10594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rvty9-00035y-K3 for qemu-devel@nongnu.org; Fri, 10 Feb 2012 12:09:09 -0500 Date: Fri, 10 Feb 2012 22:39:04 +0530 From: Amit Shah Message-ID: <20120210170903.GA475@amit.redhat.com> References: <4F351B73.9020001@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F351B73.9020001@codemonkey.ws> Subject: Re: [Qemu-devel] [PATCH 1/1] char: Add a QemuChrHandlers struct to initialise chardev handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu list On (Fri) 10 Feb 2012 [07:28:19], Anthony Liguori wrote: > On 02/10/2012 07:19 AM, Amit Shah wrote: > >Instead of passing each handler in the qemu_add_handlers() function, > >create a struct of handlers that can be passed to the function instead. > > > >Signed-off-by: Amit Shah > > Why? It's a good cleanup. > It's not a win in terms of code size. If you plan on introducing > additional handlers, perhaps you should include this in that series > where it's more appropriately justified. > > As a change on it's own, it doesn't seem to make a lot of sense. Makes the code much easier to look at. Can't really compare on code size, since there's zero change in the resulting binary, but the code just becomes more readable and manageable. Amit