From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56456)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Paul_Brook@mentor.com>) id 1RvzzM-0008Ji-4W
	for qemu-devel@nongnu.org; Fri, 10 Feb 2012 18:34:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Paul_Brook@mentor.com>) id 1RvzzL-00050U-5V
	for qemu-devel@nongnu.org; Fri, 10 Feb 2012 18:34:48 -0500
Received: from relay1.mentorg.com ([192.94.38.131]:50802)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Paul_Brook@mentor.com>) id 1RvzzK-00050K-VS
	for qemu-devel@nongnu.org; Fri, 10 Feb 2012 18:34:47 -0500
From: Paul Brook <paul@codesourcery.com>
Date: Fri, 10 Feb 2012 23:34:39 +0000
References: <alpine.DEB.2.00.1201271814280.3196@kaball-desktop>
	<4F350047.4030507@siemens.com>
	<alpine.DEB.2.00.1202101644250.7456@kaball-desktop>
In-Reply-To: <alpine.DEB.2.00.1202101644250.7456@kaball-desktop>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201202102334.40125.paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase
	minimum timeout to 1h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@siemens.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "avi@redhat.com" <avi@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

> +#ifdef CONFIG_SLIRP
> +static inline void slirp_update_timeout(uint32_t *timeout)
> +{
> +    *timeout = MIN(1000, *timeout);
> +}
> +#else
> +static inline void slirp_update_timeout(uint32_t *timeout) { }
> +#endif

Shouldn't we be testing whether slirp is actually in use? I doubt many people 
go to the effort of rebuilding without SLIRP support.

Paul