From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51934)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1RwvPp-000687-SW
	for qemu-devel@nongnu.org; Mon, 13 Feb 2012 07:53:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1RwvPo-0005kQ-Ek
	for qemu-devel@nongnu.org; Mon, 13 Feb 2012 07:53:57 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57775)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1RwvPo-0005jR-84
	for qemu-devel@nongnu.org; Mon, 13 Feb 2012 07:53:56 -0500
Date: Mon, 13 Feb 2012 14:53:50 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120213125348.GA26773@redhat.com>
References: <1329135613-26061-1-git-send-email-anthony.perard@citrix.com>
	<1329135613-26061-12-git-send-email-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1329135613-26061-12-git-send-email-anthony.perard@citrix.com>
Subject: Re: [Qemu-devel] [PATCH V6 11/11] pci: Do not check if a bus exist
 in pci_parse_devaddr.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Xen Devel <xen-devel@lists.xensource.com>, QEMU-devel <qemu-devel@nongnu.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

On Mon, Feb 13, 2012 at 12:20:13PM +0000, Anthony PERARD wrote:
> Actually, pci_parse_devaddr checks if the dom/bus of the PCI address exist. But
> this should be the jobs of a caller. In fact, the two callers of this function
> will try to retrieve the PCIBus related to the devaddr and return an error if
> they cannot.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

I agree. It's a good patch. And this will help address the bridges.
Want me to queue this?

> ---
>  hw/pci.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/pci.c b/hw/pci.c
> index ebb5de9..da7cf79 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -529,10 +529,6 @@ int pci_parse_devaddr(const char *addr, int *domp, int *busp,
>      if (*e)
>  	return -1;
>  
> -    /* Note: QEMU doesn't implement domains other than 0 */
> -    if (!pci_find_bus(pci_find_root_bus(dom), bus))
> -	return -1;
> -
>      *domp = dom;
>      *busp = bus;
>      *slotp = slot;
> -- 
> Anthony PERARD