From: "Michael S. Tsirkin" <mst@redhat.com>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: Kevin Wolf <kwolf@redhat.com>,
kvm@vger.kernel.org, seabios@seabios.org, qemu-devel@nongnu.org,
Isaku Yamahata <yamahata@valinux.co.jp>,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RFC] seabios: add OSHP method stub
Date: Tue, 14 Feb 2012 03:09:13 +0200 [thread overview]
Message-ID: <20120214010913.GA5192@redhat.com> (raw)
In-Reply-To: <20120214004837.GA14752@morn.localdomain>
On Mon, Feb 13, 2012 at 07:48:37PM -0500, Kevin O'Connor wrote:
> On Tue, Feb 14, 2012 at 02:43:45AM +0200, Michael S. Tsirkin wrote:
> > On Mon, Feb 13, 2012 at 07:34:55PM -0500, Kevin O'Connor wrote:
> > > On Mon, Feb 13, 2012 at 11:33:08AM +0200, Michael S. Tsirkin wrote:
> > > > To allow guests to load the native SHPC driver
> > > > for a bridge, we must declare an OSHP method
> > > > for the appropriate device which lets the OS
> > > > take control of the SHPC.
> > > > As we don't access SHPC at the moment, we
> > > > don't need to do anything - just report success.
> > >
> > > The patch is fine with me, but since this is really qemu/kvm specific,
> > > please provide an ack from one of the qemu/kvm maintainers.
> > >
> > > -Kevin
> >
> > I expect no problem with this,
> > though I'm wondering what makes it qemu specific.
>
> Only kvm/qemu use the ACPI tables in seabios.
>
> In a nutshell, I don't know what a SHPC is (nor OSHP), so I'm looking
> for an additional Ack.
>
> -Kevin
No problem, I'll get an Ack :)
Meanwhile - here's a summary, as far as I understand it.
Originally PCI SIG only defined the electrical
and mechanical requirements from hotplug, no standard
software interface. So it needed ACPI to drive device-specific registers
to actually do hotplug.
At some point PCISIG defined standard interfaces
for PCI hotplug. There are two of them: standard
hot plug controller (SHPC) for PCI and PCIE hotplug
for Express.
Now an OS can have a standard driver and use it
to activate hotplug functionality. This is OS hotplug (OSHP).
But what about older OSes that do not have this
driver? ACPI can support these by driving
the SHPC interface itself. This will work but
then it can conflict with the new driver in the OS.
To solve the problem, OS tells ACPI to leave SHPC
alone. There are two things OS tries to activate to do this,
in this order:
1. _OSC for global switch to native SHPC driver
2. OSHP for switch on the given bridge device
If none of the above are present, or if they fail,
OS assumes ACPI wants control of the SHPC registers
and won't touch them.
Hope above makes sense.
--
MST
next prev parent reply other threads:[~2012-02-14 1:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 9:15 [Qemu-devel] [PATCHv2-RFC 0/2] RFC: standard pci bridge device Michael S. Tsirkin
2012-02-13 9:15 ` [Qemu-devel] [PATCHv2-RFC 1/2] shpc: standard hot plug controller Michael S. Tsirkin
2012-02-13 10:03 ` Isaku Yamahata
2012-02-13 11:49 ` Michael S. Tsirkin
2012-02-13 14:30 ` Isaku Yamahata
2012-02-13 14:49 ` Michael S. Tsirkin
2012-02-17 13:20 ` Gerd Hoffmann
2012-02-13 9:16 ` [Qemu-devel] [PATCHv2-RFC 2/2] pci: add standard bridge device Michael S. Tsirkin
2012-02-17 13:25 ` Gerd Hoffmann
2012-02-19 14:57 ` Michael S. Tsirkin
2012-02-19 23:44 ` Michael S. Tsirkin
2012-02-17 13:33 ` Gerd Hoffmann
2012-02-20 22:40 ` Michael S. Tsirkin
2012-02-21 8:02 ` Gerd Hoffmann
2012-02-13 9:33 ` [Qemu-devel] [PATCH RFC] seabios: add OSHP method stub Michael S. Tsirkin
2012-02-14 0:34 ` Kevin O'Connor
2012-02-14 0:43 ` Michael S. Tsirkin
2012-02-14 0:48 ` Kevin O'Connor
2012-02-14 1:09 ` Michael S. Tsirkin [this message]
2012-02-14 12:49 ` Paul Brook
2012-02-14 13:37 ` Michael S. Tsirkin
2012-02-14 13:47 ` Paul Brook
2012-02-14 14:11 ` Michael S. Tsirkin
2012-02-29 11:25 ` [Qemu-devel] [SeaBIOS] " Gerd Hoffmann
2012-02-13 9:38 ` [Qemu-devel] [PATCHv2-RFC 0/2] RFC: standard pci bridge device Wen Congyang
2012-02-13 9:56 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120214010913.GA5192@redhat.com \
--to=mst@redhat.com \
--cc=avi@redhat.com \
--cc=kevin@koconnor.net \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).