From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxDtc-0002JL-O1 for qemu-devel@nongnu.org; Tue, 14 Feb 2012 03:37:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxDtb-0002ar-JN for qemu-devel@nongnu.org; Tue, 14 Feb 2012 03:37:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:19478) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxDtb-0002aT-Cm for qemu-devel@nongnu.org; Tue, 14 Feb 2012 03:37:55 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1E8bsae027738 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 14 Feb 2012 03:37:54 -0500 Date: Tue, 14 Feb 2012 10:37:53 +0200 From: Gleb Natapov Message-ID: <20120214083753.GZ18866@redhat.com> References: <1328807143-29499-1-git-send-email-kraxel@redhat.com> <1328807143-29499-6-git-send-email-kraxel@redhat.com> <20120213092123.GV18866@redhat.com> <4F3A18DA.4070405@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F3A18DA.4070405@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 05/11] suspend: add infrastructure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Tue, Feb 14, 2012 at 09:18:34AM +0100, Gerd Hoffmann wrote: > Hi, > > > Shouldn't we stop the whole VM at some point, not only vcpu that > > does ACPI IO? May be I missed where it is done in the patch series. > > It isn't hidden elsewhere, qemu doesn't do it. The code was like that > before, and I think the reason is that the guest has to stop the other > cpus before entering s3. > Current code calls qemu_system_reset_request() which takes care of stopping (and reseting) all vcpus (and rest of the machine) by setting reset_requested flag immediately on suspend. We cannot just stop current cpu on S3 and delay reset till wakeup since guest can leave other vcpus in spinning state and they will take 100% of host cpu while guest is suspended. I think it is also important to reset all device immediately to ensure that no device will do DMA into main memory after suspend. Technically if this happens it would be a guest bug since guest should make sure that devices are stopped before entering S3, but I wouldn't want to debug such bug report :) -- Gleb.