From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40944)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Paul_Brook@mentor.com>) id 1RxIju-00045r-DR
	for qemu-devel@nongnu.org; Tue, 14 Feb 2012 08:48:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Paul_Brook@mentor.com>) id 1RxIjm-0003iZ-V6
	for qemu-devel@nongnu.org; Tue, 14 Feb 2012 08:48:14 -0500
Received: from relay1.mentorg.com ([192.94.38.131]:51275)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Paul_Brook@mentor.com>) id 1RxIjm-0003iO-M2
	for qemu-devel@nongnu.org; Tue, 14 Feb 2012 08:48:06 -0500
From: Paul Brook <paul@codesourcery.com>
Date: Tue, 14 Feb 2012 13:47:59 +0000
References: <cover.1329124507.git.mst@redhat.com>
	<201202141249.09301.paul@codesourcery.com>
	<20120214133727.GA23647@redhat.com>
In-Reply-To: <20120214133727.GA23647@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201202141348.00060.paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH RFC] seabios: add OSHP method stub
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, kvm@vger.kernel.org, seabios@seabios.org, qemu-devel@nongnu.org, Isaku Yamahata <yamahata@valinux.co.jp>, Kevin O'Connor <kevin@koconnor.net>, Avi Kivity <avi@redhat.com>

> > > Now an OS can have a standard driver and use it
> > > to activate hotplug functionality. This is OS hotplug (OSHP).
> > 
> > So presumably this will work on targets that don't have ACPI?
> > Assuming a competent guest OS of course.  Have you tested this?
> 
> This being the qemu side of things? I run Linux
> and verified that it calls OSHP and afterwards,
> runs the native driver and handles hotplug/unplug
> without invoking ACPI at all.

I mean using your shiny new hotplug PCI-PCI bridge on arm/ppc/mips targets 
(i.e anything other than x86 PC).  From your description it sounds like it 
*should* work.
 
> It seems that at least the SHPC driver in linux
> doesn't work if you don't have an acpi table
> with the OSHP method - not many people run with acpi=off
> nowdays, so it's probably just a bug.
> I'll check how hard it is to fix this.

Targets other than x86 don't have ACPI to start with.

Paul