From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxeMf-0003HF-GE for qemu-devel@nongnu.org; Wed, 15 Feb 2012 07:53:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxeMV-0002wC-Vi for qemu-devel@nongnu.org; Wed, 15 Feb 2012 07:53:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5842) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxeMV-0002w8-ND for qemu-devel@nongnu.org; Wed, 15 Feb 2012 07:53:31 -0500 Date: Wed, 15 Feb 2012 10:53:28 -0200 From: Luiz Capitulino Message-ID: <20120215105328.71e1a5b5@doriath.home> In-Reply-To: <4F3B74BE.30802@siemens.com> References: <1328902266-25308-1-git-send-email-lcapitulino@redhat.com> <1328902266-25308-6-git-send-email-lcapitulino@redhat.com> <4F3B74BE.30802@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/6] Purge migration of (almost) everything to do with monitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, quintela@redhat.com On Wed, 15 Feb 2012 10:02:54 +0100 Jan Kiszka wrote: > On 2012-02-10 20:31, Luiz Capitulino wrote: > > The Monitor object is passed back and forth within the migration/savevm > > code so that it can print errors and progress to the user. > > > > However, that approach assumes a HMP monitor, being completely invalid > > in QMP. > > > > This commit drops almost every single usage of the Monitor object, all > > monitor_printf() calls have been converted into DPRINTF() ones. > > Particularly NACK on this. Either the information is useless anyway, > then remove it. Otherwise, keep it for channels that can properly > display it (AKA HMP). I bet the latter can easily be achieved by > providing non-printing Monitor objects over QMP instances. I will consider dropping it :) I can think of two ways of displaying status in HMP (considering the new HMP/QMP split design): 1. We add all progress status information to a query command, and let HMP poll it (manually by the user or automatically from a timer) 2. We emit an event whenever the progress status changes (seems a bit overkill)