From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45539)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Rxzsp-0003Ba-3r
	for qemu-devel@nongnu.org; Thu, 16 Feb 2012 06:52:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Rxzsj-0003dC-GY
	for qemu-devel@nongnu.org; Thu, 16 Feb 2012 06:52:19 -0500
Received: from mx1.redhat.com ([209.132.183.28]:61972)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Rxzsj-0003d6-8i
	for qemu-devel@nongnu.org; Thu, 16 Feb 2012 06:52:13 -0500
Date: Thu, 16 Feb 2012 13:52:17 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120216115217.GA5360@redhat.com>
References: <20120215184515.GA32249@redhat.com> <4F3BFFB3.5000806@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F3BFFB3.5000806@siemens.com>
Subject: Re: [Qemu-devel] [PATCH] slirp: kill ugly macros
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Wed, Feb 15, 2012 at 07:55:47PM +0100, Jan Kiszka wrote:
> On 2012-02-15 19:45, Michael S. Tsirkin wrote:
> > Remove ugly macros for field names,
> > change done by the following script:
> > 
> > s#\bifq_prev\b#m_prev#g;
> > s#\bifq_next\b#m_next#g;
> > s#\bifs_prev\b#m_prevpkt#g;
> > s#\bifs_next\b#m_nextpkt#g;
> > s#\bifq_so\b#m_so#g;
> > s#\bm_next\b#m_hdr.mh_next#g;
> > s#\bm_prev\b#m_hdr.mh_prev#g;
> > s#\bm_nextpkt\b#m_hdr.mh_nextpkt#g;
> > s#\bm_prevpkt\b#m_hdr.mh_prevpkt#g;
> > s#\bm_flags\b#m_hdr.mh_flags#g;
> > s#\bm_len\b#m_hdr.mh_len#g;
> > s#\bm_data\b#m_hdr.mh_data#g;
> > s#\bm_size\b#m_hdr.mh_size#g;
> > s#\bm_dat\b#M_dat.m_dat_#g;
> > s#\bm_ext\b#M_dat.m_ext_#g;
> 
> Could you convert M_dat to m_dat as well (do not script, it's also a
> type)? It looks strange.
> 
> Thanks in any case!
> Jan

So as you probably saw, that type can be dropped,
then we can script it easily.

> -- 
> Siemens AG, Corporate Technology, CT T DE IT 1
> Corporate Competence Center Embedded Linux