From: Luiz Capitulino <lcapitulino@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
pbonzini@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event
Date: Fri, 17 Feb 2012 09:56:07 -0200 [thread overview]
Message-ID: <20120217095607.24dbcd58@doriath.home> (raw)
In-Reply-To: <m3obsx4rc3.fsf@blackfin.pond.sub.org>
On Fri, 17 Feb 2012 12:44:28 +0100
Markus Armbruster <armbru@redhat.com> wrote:
> >> I figure Luiz's patch works. But maybe it could be simplified some by
> >> replacing bdrv_dev_change_media_cb() by a "open/close tray" callback
> >> that returns whether it moved. bdrv_dev_change_media_cb() would then
> >> simply open the tray, emit event if it moved, close the tray, emit event
> >> if it moved.
> >
> > Yes, I had the same impression after reading the first few paragraphs of
> > your analysis (which looks right to me).
>
> If I understand Luiz correctly, he'd like to do that in a follow-up
> patch.
Yes, but as I said I'm not completely sure what's the best thing to do here,
and this may take some time, but I'll do it.
next prev parent reply other threads:[~2012-02-17 11:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 18:42 [Qemu-devel] [PATCH v2 0/4]: QMP: add BLOCK_MEDIUM_EJECT event Luiz Capitulino
2012-02-15 18:42 ` [Qemu-devel] [PATCH 1/4] block: Rename bdrv_mon_event() & BlockMonEventAction Luiz Capitulino
2012-02-15 18:42 ` [Qemu-devel] [PATCH 2/4] block: bdrv_eject(): Make eject_flag a real bool Luiz Capitulino
2012-02-15 18:42 ` [Qemu-devel] [PATCH 3/4] block: bdrv_eject(): Add tray_changed parameter Luiz Capitulino
2012-02-15 18:42 ` [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event Luiz Capitulino
2012-02-16 9:25 ` Markus Armbruster
2012-02-16 13:14 ` Luiz Capitulino
2012-02-16 13:19 ` Luiz Capitulino
2012-02-16 13:31 ` Kevin Wolf
2012-02-16 14:10 ` Luiz Capitulino
2012-02-17 10:32 ` Paolo Bonzini
2012-02-17 11:03 ` Kevin Wolf
2012-02-17 11:48 ` Markus Armbruster
2012-02-17 12:12 ` Kevin Wolf
2012-02-17 12:43 ` Markus Armbruster
2012-02-16 18:30 ` Markus Armbruster
2012-02-16 19:08 ` Luiz Capitulino
2012-02-17 9:53 ` Kevin Wolf
2012-02-17 10:48 ` Paolo Bonzini
2012-02-17 11:50 ` Markus Armbruster
2012-02-17 11:44 ` Markus Armbruster
2012-02-17 11:56 ` Luiz Capitulino [this message]
2012-02-17 10:45 ` Paolo Bonzini
2012-02-17 11:57 ` Markus Armbruster
2012-02-17 10:49 ` [Qemu-devel] [PATCH v2 0/4]: QMP: " Paolo Bonzini
2012-02-17 11:58 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217095607.24dbcd58@doriath.home \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).